COMMON blocks repeated with different sizes in generator code

[makortel]

Spinning off #50620 (comment) into a separate issue

It's SAVEd DATA for a COMMON block, and the dimensions aren't consistent.

cmssw/GeneratorInterface/AMPTInterface/src/hipyset1.35.f

Line 6139 in c801033

COMMON/PYSUBS/MSEL,MSUB(200),KFIN(2,-40:40),CKIN(200)

cmssw/GeneratorInterface/Core/src/pydata.F

Line 337 in c801033

COMMON/PYSUBS/MSEL,MSELPD,MSUB(500),KFIN(2,-40:40),CKIN(200)

If these are supposed to communicate with each other, then the declarations have to be reconciled. If they aren't intended to be the same common block across shared objects, one set ought to be renamed. As is, Chris is correct that is just going to blow up again, as Fortran77 has no protection against mismatched common blocks.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @makortel.

@Dr15Jones, @ftenchini, @makortel, @mandrenguyen, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign generators

[cmsbuild]

New categories assigned: generators

@lviliani,@mkirsano,@sensrcn,@theofil you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

@cms-sw/generators-l2 As Dan noted, this is a ticking time bomb.

[lviliani]

Let me tag @stahlleiton and @DickyChant who are among the original developers of AMPTInterface if I understand correctly. They might have some ideas.

[stahlleiton]

Let me tag @stahlleiton and @DickyChant who are among the original developers of AMPTInterface if I understand correctly. They might have some ideas.

I have not worked on the AMPT generator. Maybe @mandrenguyen might know who was the responsible or developer of that generator in CMSSW.

[mkirsano]

According to my information (could be not updated) the responsible persons were Kurt Jung, Colin Baus

[Dr15Jones]

Doing

cdj@MAC-140789 src % git grep --cached PYSUBS | awk -F'/' '{print $1"/"$2}' | sort -u

shows that the following 5 packages all declare or use the common block PYSUBS.

GeneratorInterface/AMPTInterface
GeneratorInterface/Core
GeneratorInterface/GenExtensions
GeneratorInterface/HijingInterface
GeneratorInterface/Pythia6Interface

In addition, looking for declarations of PYINIT which is used by pythia6 to initialize itself finds

cdj@MAC-140789 src % git grep --cached PYINIT | grep SUBROUTINE
GeneratorInterface/AMPTInterface/src/hipyset1.35.f:      SUBROUTINE PYINIT(FRAME,BEAM,TARGET,WIN)  
GeneratorInterface/HijingInterface/src/hipyset1.35.f:      SUBROUTINE PYINIT(FRAME,BEAM,TARGET,WIN)  

So these two packages appear to have their own version of pythia6?