Spinning off #50731 (comment)
- The
IfLogDebug() macro is intended for run-time condition evaluation, so IfLogDebug(DEBUG, ...) (with DEBUG defined at compile time) is kind-of unintended use of that
- The
DecayGraph.h has unnamed namespace, generally those should be avoided in headers
- The
DecayGraph.h declares messageCategoryGraph_, I'd argue messageCategoryGraph_ is a rather generic name, although it is in the aforementioned anonymous namespace so it won't create ODR violations in practice
- The
DecayGraph.h seems to be used only in SimGeneral/CaloAnalysis/plugins. How about moving DecayGraph.h there so that these patterns would not spread elsewhere?
Spinning off #50731 (comment)
IfLogDebug()macro is intended for run-time condition evaluation, soIfLogDebug(DEBUG, ...)(withDEBUGdefined at compile time) is kind-of unintended use of thatDecayGraph.hhas unnamed namespace, generally those should be avoided in headersDecayGraph.hdeclaresmessageCategoryGraph_, I'd arguemessageCategoryGraph_is a rather generic name, although it is in the aforementioned anonymous namespace so it won't create ODR violations in practiceDecayGraph.hseems to be used only inSimGeneral/CaloAnalysis/plugins. How about movingDecayGraph.hthere so that these patterns would not spread elsewhere?