Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432
Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432simplefarmer69 wants to merge 4 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
📝 WalkthroughWalkthroughThis PR updates token-list metadata (timestamp and version) and modifies ChangesToken List Update
Possibly related issues
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/public/CowSwap.json (1)
2167-2182: ⚡ Quick winKeep
chainId: 1tokens in the mainnet section for consistency.These two Ethereum mainnet entries are appended after the
chainId: 59144block. Please place them with the existingchainId: 1tokens (ideally preserving the file’s ordering convention) to avoid structural drift.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/public/CowSwap.json` around lines 2167 - 2182, Move the two token objects for K9 (address 0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address 0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId 59144 and insert them into the existing chainId: 1 (mainnet) token list so they reside with other mainnet entries, preserving the file's ordering convention (alphabetical or existing insertion pattern) and ensuring commas/JSON structure remain valid after relocation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: You added two tokens (addresses
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930 and
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) but did not update the token-list
metadata; open src/public/CowSwap.json and update the top-level "timestamp" to
the current ISO date/time and increment the patch version in "version" (e.g.,
7.4.0 → 7.4.1) so consumers and caches detect the change; ensure the "timestamp"
and "version" fields are consistent with this addition.
---
Nitpick comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: Move the two token objects for K9 (address
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId
59144 and insert them into the existing chainId: 1 (mainnet) token list so they
reside with other mainnet entries, preserving the file's ordering convention
(alphabetical or existing insertion pattern) and ensuring commas/JSON structure
remain valid after relocation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Thanks for the review! Fixed in the latest commit: K9 and PUPCUP tokens are now sorted with the other |
|
I have read the CLA Document and I hereby sign the CLA |
|
Friendly check-in -- happy to address anything that would help this land. For reference on the two tokens: K9 (
PUPCUP (
Both have logos hosted on TrustWallet (referenced in the PR) and are tradeable on Uniswap V3 on Ethereum. CodeRabbit pre-merge checks are all green and the CLA is signed. Let me know if anything needs adjusting. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/public/CowSwap.json`:
- Around line 2175-2189: The two token objects for K9 (address
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930, symbol K9) and World Pup Coin /
PUPCUP (address 0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef, symbol PUPCUP) were
inserted after a chainId 59144 block; move each entire object so they appear
with the other chainId: 1 entries (grouped with mainnet tokens) to preserve
ordering and grouping consistency in the JSON array.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| { | ||
| "chainId": 1, | ||
| "address": "0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930", | ||
| "name": "K9", | ||
| "symbol": "K9", | ||
| "decimals": 18, | ||
| "logoURI": "https://anvil.clutch.market/token-k9.png" | ||
| }, | ||
| { | ||
| "chainId": 1, | ||
| "address": "0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef", | ||
| "name": "World Pup Coin", | ||
| "symbol": "PUPCUP", | ||
| "decimals": 18, | ||
| "logoURI": "https://anvil.clutch.market/token-pupcup.png" |
There was a problem hiding this comment.
Move K9 and PUPCUP into the chainId 1 section.
Line 2176 and Line 2184 add chainId: 1 tokens after the chainId 59144 block, which breaks the list’s ordering/grouping pattern and makes deterministic maintenance harder. Place both entries with the other mainnet tokens (near the other chainId: 1 objects).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/public/CowSwap.json` around lines 2175 - 2189, The two token objects for
K9 (address 0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930, symbol K9) and World Pup
Coin / PUPCUP (address 0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef, symbol
PUPCUP) were inserted after a chainId 59144 block; move each entire object so
they appear with the other chainId: 1 entries (grouped with mainnet tokens) to
preserve ordering and grouping consistency in the JSON array.
1 participant
Token Addition Request
Adding K9 and PUPCUP (World Pup Coin) — two ERC-20 tokens from the Clutch Puppies DeFi ecosystem on Ethereum mainnet.
K9
PUPCUP (World Pup Coin)
Both tokens are verified on Etherscan, scored 100/100 on TokenSniffer, and already listed on TrustWallet assets.
Summary by CodeRabbit
New Features
Chores