Skip to content

Commit 1d48c47

Browse files
authored
xGroup: Refactored Principal Resolution Functions for Enhanced Virtual Account Support (#764)
* Refactored Principal Resolution Functions for Enhanced Virtual Account Support - Enhanced Test-IsLocalMachine to recognize 'IIS APPPOOL' and 'NT VIRTUAL MACHINE' as local machine scopes, improving virtual account type coverage. - Updated Split-MemberName to preserve original scope, allowing local accounts that do not use the computer name to be resolved. - Extended Find-Principal with a new Scope parameter, enabling searches additional local machine scopes. - Augmented Find-Principal to handle a predefined list of NT account scopes ('NT Authority', 'NT Service', 'IIS APPPOOL', 'NT Virtual Machine'), utilizing System.Security.Principal.NTAccount for SID resolution. This enhancement focuses on local virtual account identification. - Implemented new integration tests for ConvertTo-Principal to verify local, virtual account resolution. - Introduced Get-ScopeFromDistinguishedName to accurately parse scope from distinguished names, addressing issues with multiple domain components and escaped commas. - Added unit tests for Get-ScopeFromDistinguishedName, ensuring functional correctness. - Adjusted outside domain test to expect 'domain.com' instead of 'domain'. * Updating chagelog * Fixing assertion in xDSCWebService for mock call count. * - Modify assertion for the number of calls to the Test-Path mock to account for the short-circuiting of the if conditions on line 449 of DSC_xDSCWebService.psm1 preventing the third condition from being evaluated. * - Fixing issues identified during the pull request review process
1 parent 7703bb1 commit 1d48c47

5 files changed

Lines changed: 219 additions & 106 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
55

66
## [Unreleased]
77

8+
- xGroup
9+
- Fixed a bug where the resource would fail if any of the group members were local, virtual accounts. - Fixes [Issue #763](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/763)
10+
- Fixed a bug where members with distinguished names that contained multiple domain components would only have the first domain component included in the account scope.
11+
- Fixed a bug where members with distinguished names that contained an escaped comma would not be parsed correctly.
812
- xPackage
913
- Fixed a bug not allowing using the file hash of an installer [Issue #702](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/702).
1014
- xPSDesiredStateConfiguration
1115
- Updated CI pipeline to remove Azure DevOps deprecated Windows Server 2016
1216
image and add Windows Server 2022 - Fixes [Issue #752](https://github.com/dsccommunity/xPSDesiredStateConfiguration/issues/752).
1317
- xDSCWebService
14-
- Fixed a bug where the variable ```DscWebServiceDefaultAppPoolName``` is not set in the resource xDSCWebService since version 9.0.0 as a result of module refactoring.
18+
- Fixed a bug where the variable ```DscWebServiceDefaultAppPoolName``` is not set in the resource xDSCWebService since version 9.0.0 as a result of module refactoring
1519
### Fixed
1620

1721
- xPSDesiredStateConfiguration

0 commit comments

Comments
 (0)