[Gtk4] Fix blurry images on widgets at HiDPI#3397
Conversation
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
It looks ok to me. I have an open question, which I think isn't relevant, but I thought best to check.
|
|
||
| static GdkPaintableFlags swt_scaled_paintable_get_flags (GdkPaintable* paintable) | ||
| { | ||
| return GDK_PAINTABLE_STATIC_SIZE | GDK_PAINTABLE_STATIC_CONTENTS; |
There was a problem hiding this comment.
Can the gdk_paintable_snapshot (GDK_PAINTABLE (self->texture)... ever paint differently or need to invalidate? i.e. is the texture always static contents too?
Ref is this demo from GTK4 which checks the child paintable for static
I am not sure this is wrong as we tend to have the paintables (texture) be rather static and recreated when changed.
There was a problem hiding this comment.
It is always static as GdkTexture is wrapped (https://docs.gtk.org/gdk4/class.Texture.html) and it's clearly stated in its documentation "It is primarily meant for pixel data that will not change over multiple frames, and will be used for a long time." . What's in the demo is due to it handling other types of GdkPaintable e.g https://gnome.pages.gitlab.gnome.org/gdk-pixbuf/gdk-pixbuf/class.PixbufAnimation.html or https://docs.gtk.org/gtk4/class.MediaStream.html but it's not our case.
On GTK4, GtkPicture measures a GdkTexture by its device-pixel intrinsic size, which inflated widgets at HiDPI. Introduce a custom scale-aware Gtk4-only GdkPaintable (SwtScaledPaintable) that reports the logical intrinsic size while drawing the full-resolution texture, giving crisp images at the correct widget size. Use that paintable into the GtkPicture consumers (Button, Label, ExpandItem, ToolItem) and remove the GTK4 downscale in ImageList.
2 participants
On GTK4, GtkPicture measures a GdkTexture by its device-pixel intrinsic size, which inflated widgets at HiDPI.
Introduce a custom scale-aware Gtk4-only GdkPaintable (SwtScaledPaintable) that reports the logical intrinsic size while drawing the full-resolution texture, giving crisp images at the correct widget size.
Use that paintable into the GtkPicture consumers (Button, Label, ExpandItem, ToolItem) and remove the GTK4 downscale in ImageList.