Replace arch and req to S-CORE#2974
Conversation
PandaeDo
requested review from
a team,
FScholPer,
antonkri,
johannes-esr and
qor-lb
as code owners
|
The created documentation from the pull request is available at: docu-html |
| :status: valid | ||
| :belongs_to: feat__persistency | ||
|
|
||
| .. uml:: _assets/kvs_static_view.puml |
There was a problem hiding this comment.
Is there any reason to use puml instead of the integrated draw function of sphinx ? Outside the appearance (all other features look different) it does not allow the automated drawing, but needs manual created drawings and needs manual checks.
There was a problem hiding this comment.
I don't know the exact reason. But I guess this was the stand of knowledge the authors had as the initially created the architecture over one year ago. But I take this as a point for the feature team meeting next week. We have some changes and will plan to update documents. This might be a good chance also to update the architecture as you described.
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
not all architecture elements are needed on score repo, see inline comments
|
|
||
| .. toctree:: | ||
| architecture/index.rst | ||
| architecture/chklst_arc_inspection.rst |
There was a problem hiding this comment.
architecture checklist should be stored in the module repo, as mainly the static and dynamic views are inspected which are located there. See also https://eclipse-score.github.io/score/main/contribute/general/folder.html#platform-folder-structure
There was a problem hiding this comment.
Changed as suggested
|
|
||
| .. needextend:: is_external == False and "persistency/requirements" in docname | ||
| :+tags: persistency | ||
|
|
There was a problem hiding this comment.
feature level aou were removed here, these should be in module repository now, see eclipse-score/persistency#296 - but not all are covered. Missing is aou_req__persistency__appl_design. Why?
There was a problem hiding this comment.
It was removed because of a finding regarding inconsistent aos #2667
| :status: valid | ||
| :provides: logic_arc_int__persistency__interface | ||
|
|
||
| .. comp:: persistency::kvs |
There was a problem hiding this comment.
The full architecture on feature level is part of the module repository. Here should only be the feature definition and the (logical) interfaces of the feature.
There was a problem hiding this comment.
Changed as suggested
3 participants
After clarification in process community today, documents of architecture and requirements, also the feature request will be placed again in S-CORE. #2964