Why is there no user property for repository in tycho-p2-repository-plugin:modify-composite-repository

[wilbert-alberts]

I'm trying to modify a composite repostiory after my build has finished. I know what I want to see added to the composite repository. Therefore I'm trying to run maven with a goal like org.eclipse.tycho:tycho-p2-repository-plugin:5.0.0:modify-composite-repository.

This plugin requires the 'repository' property to be set to the source repository. I expected something like
mvn ... -Drepository="http://...."
However, there is no user property for the repository parameter.

Why not?

Regards,
Wilbert

[merks]

It's probably and oversight? @HannesWell

Maybe you want to contribute it via a pull request?

[laeubi]

The main reason is that a repository is a complex type and you can not yet supply complex types as user properties.

One might use a workaround and use an additional parameter (e.g. repositoryUrl) and give it a user property then in the code one has to check for both.

[HannesWell]

One might use a workaround and use an additional parameter (e.g. repositoryUrl) and give it a user property then in the code one has to check for both.

Yes that would work. If both are present, I think the complex type should take precedence.

For eclipse-platform releng, this basically modeled like that in the calling pom.xml:
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/84a2bb49c95de3bb49c763c80c07f2420be62a1a/eclipse-platform-parent/pom.xml#L1127-L1129

which in turn is then called via the CLI in:
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/84a2bb49c95de3bb49c763c80c07f2420be62a1a/JenkinsJobs/Releng/modifyP2CompositeRepository.jenkinsfile#L44

@wilbert-alberts are you interested in contributing a corresponding PR to implement this?

Ideally for

tycho/tycho-p2-repository-plugin/src/main/java/org/eclipse/tycho/plugins/p2/repository/ModifyCompositeRepositoryMojo.java

Lines 59 to 60 in 40dadec

	@Parameter
	private Repository repository;

and

tycho/tycho-p2-repository-plugin/src/main/java/org/eclipse/tycho/plugins/p2/repository/ModifyRepositoryPropertiesMojo.java

Lines 56 to 57 in 40dadec

	@Parameter
	private Repository repository;

[wilbert-alberts]

@HannesWell: I will take a look at it. The change as such doesn't seem to be too complex. But as it would be my first contribution, going through the work of setting up a dev env etc. would bring some hassle. So don't hold your breath...

[HannesWell]

Don't worry and take your time and don't hesitate to ask if you encounter problems in the contribution process.
We actively support new contributors and encourage everyone to do it.

For me it's not urgent as we have the mentioned workaround, still it would be nice to have.