Improve TransformVisitor

Author: emacsway

grade/internal/infrastructure/seedwork/specification/transform_visitor.go

@@ -13,13 +13,11 @@ var (
 
 func NewTransformVisitor(context Context) *TransformVisitor {
 	return &TransformVisitor{
-		isChanged: false,
-		Context:   context,
+		Context: context,
 	}
 }
 
 type TransformVisitor struct {
-	isChanged            bool
 	compositeExpressions []CompositeExpression
 	currentNode          s.Visitable
 	Context
@@ -107,7 +105,7 @@ func (v *TransformVisitor) VisitInfix(n s.InfixNode) error {
 	}
 	if newNode != nil {
 		v.currentNode = newNode
-		v.isChanged = true
+		v.currentNode.Accept(v)
 	} else {
 		v.currentNode = s.NewInfixNode(left, n.Operator(), right, n.Associativity())
 	}
@@ -134,10 +132,6 @@ func (v *TransformVisitor) buildNodeFromCompositeExpressions(n s.InfixNode) (s.V
 	return nil, nil
 }
 
-func (v TransformVisitor) IsChanged() bool {
-	return v.isChanged
-}
-
 func (v TransformVisitor) Result() (s.Visitable, error) {
 	return v.currentNode, nil
 }

grade/internal/infrastructure/seedwork/specification/transform_visitor_test.go

@@ -50,19 +50,14 @@ func (ss SomethingSpecification) Evaluate( /* session session.PgxSession */ ) (
 	sql string, params []driver.Valuer, err error,
 ) {
 	exp := ss.Expression()
-	for i := 1; i <= 10; i++ {
-		v := NewTransformVisitor(TestContext{})
-		err := exp.Accept(v)
-		if err != nil {
-			return "", nil, err
-		}
-		exp, err = v.Result()
-		if err != nil {
-			return "", nil, err
-		}
-		if !v.IsChanged() {
-			break
-		}
+	tv := NewTransformVisitor(TestContext{})
+	err = exp.Accept(tv)
+	if err != nil {
+		return "", nil, err
+	}
+	exp, err = tv.Result()
+	if err != nil {
+		return "", nil, err
 	}
 	v := NewPostgresqlVisitor(TestContext{})
 	err = exp.Accept(v)