Commit 213bd20
Fix LibevQuicAsyncUDPSocket build on macOS (recvmmsg)
Summary:
`recvmmsg` is a Linux-only syscall and is absent from Darwin's libc. `LibevQuicAsyncUDPSocket::recvmmsg` guarded the direct `::recvmmsg` call with only `#if !FOLLY_MOBILE`, but macOS desktop is not `FOLLY_MOBILE`, so the branch was compiled on Mac builds. With no global `::recvmmsg`, the identifier resolved to the class's own member function, producing `no member named 'recvmmsg' in the global namespace` and blocking any macOS app that links MNS/mvfst's libev QUIC (HTTP/3) path (e.g. the Remote Desktop Mac companion).
Exclude `__APPLE__` from the guard so macOS falls through to the existing `recvmsg` loop fallback, matching how folly's own `netops::recvmmsg` degrades on platforms lacking the syscall.
Reviewed By: kvtsoy
Differential Revision: D112124811
fbshipit-source-id: ba7805cd42a49d992b7589e0f05b6947d81571191 parent 96ac25f commit 213bd20
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
682 | 682 | | |
683 | 683 | | |
684 | 684 | | |
685 | | - | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
686 | 688 | | |
687 | 689 | | |
688 | 690 | | |
| |||
0 commit comments