Skip to content

Commit d5fcd14

Browse files
r-barnesmeta-codesync[bot]
authored andcommitted
ci: fix Mac builds broken by llvm@20 pin in #47
Summary: The `llvm@20` pin that landed in facebook/rebalancer#47 breaks Mac builds. Homebrew's folly bottles are compiled against LLVM 22's libc++; linking against LLVM 20 produces `ld: symbol(s) not found for architecture arm64` on libfolly. The correct fix (which was developed but didn't make it into the facebook/rebalancer#47 squash merge) is to: 1. Revert the `llvm@20` pin back to `brew install llvm` (LLVM 22) in `getdeps_mac.yml`, `before_all_macos.sh`, and `wheels.yml` 2. Remove `fmt` from `[homebrew]` in `manifests/fmt` so getdeps builds fmt 12.1.0 from source as a static library — no `-DFMT_SHARED`, so `fmt::format` stays header-inline and visible under LLVM 22's libc++ This matches Linux behavior (getdeps already builds fmt from source there). X-link: facebook/rebalancer#48 Reviewed By: yangneu2015 Differential Revision: D110918926 Pulled By: r-barnes fbshipit-source-id: fd15b2f83f14bd8c6077a6ecf210eeebf106e459
1 parent fa05bde commit d5fcd14

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

  • build/fbcode_builder/manifests

build/fbcode_builder/manifests/fmt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,5 @@ FMT_DOC = OFF
2020
[cmake.defines.feature_shared_libs=on]
2121
BUILD_SHARED_LIBS = ON
2222

23-
[homebrew]
24-
fmt
25-
2623
[rpms.distro=fedora]
2724
fmt-devel

0 commit comments

Comments
 (0)