Skip to content

Commit 90e0096

Browse files
committed
Renamed tasks names to generateBuildConfigClasses
1 parent a9796c6 commit 90e0096

4 files changed

Lines changed: 9 additions & 10 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def generateResourcesConstants = tasks.register("generateResourcesConstants") {
353353
}
354354
}
355355
356-
tasks.generateBuildConfig {
356+
tasks.generateBuildConfigClasses {
357357
dependsOn(generateResourcesConstants)
358358
}
359359
```

demo-project/generic/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ buildConfig {
3535
// everything below here are just helper code to allow testing the plugin as we can't rely on any framework like JUnit
3636

3737
val generateBuildConfigTest by tasks.registering(AssertGeneratedFile::class) {
38-
generatedDir.set(tasks.generateBuildConfig.flatMap { it.outputDir })
38+
generatedDir.set(tasks.generateBuildConfigClasses.flatMap { it.outputDir })
3939
filePath.set("com/github/gmazzo/buildconfig/demos/generic/BuildConfig.java")
4040
expectedContent.set(
4141
"""
@@ -62,7 +62,7 @@ val generateBuildConfigTest by tasks.registering(AssertGeneratedFile::class) {
6262
}
6363

6464
val generateBuildResourcesBuildConfigTest by tasks.registering(AssertGeneratedFile::class) {
65-
generatedDir.set(tasks.generateBuildConfig.flatMap { it.outputDir })
65+
generatedDir.set(tasks.generateBuildConfigClasses.flatMap { it.outputDir })
6666
filePath.set("com/github/gmazzo/buildconfig/demos/generic/BuildResources.java")
6767
expectedContent.set(
6868
"""

plugin/src/main/kotlin/com/github/gmazzo/buildconfig/BuildConfigPlugin.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ public class BuildConfigPlugin : Plugin<Project> {
9595
defaultSS -> ""
9696
else -> sourceSet.name.replace("[_-]".toRegex(), "").capitalized
9797
}
98-
val taskPrefix = if (plugins.hasPlugin("com.android.base")) "NonAndroid" else ""
9998

10099
sourceSet.className
101100
.convention("${prefix}BuildConfig")
@@ -145,7 +144,7 @@ public class BuildConfigPlugin : Plugin<Project> {
145144

146145
configureFields(sourceSet.buildConfigFields)
147146

148-
sourceSet.generateTask = tasks.register<BuildConfigTask>("generate${prefix}${taskPrefix}BuildConfig") {
147+
sourceSet.generateTask = tasks.register<BuildConfigTask>("generate${prefix}BuildConfigClasses") {
149148
group = "BuildConfig"
150149
description = "Generates the build constants class for '${sourceSet.name}' source"
151150

plugin/src/test/kotlin/com/github/gmazzo/buildconfig/BuildConfigTaskCacheabilityTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,26 +74,26 @@ class BuildConfigTaskCacheabilityTest {
7474
buildScript.appendText("buildConfig.useJavaOutput()\n")
7575

7676
val firstRun = runner.build()
77-
assertEquals(TaskOutcome.SUCCESS, firstRun.task(":generateBuildConfig")?.outcome)
77+
assertEquals(TaskOutcome.SUCCESS, firstRun.task(":generateBuildConfigClasses")?.outcome)
7878

7979
val secondRun = runner.build()
80-
assertEquals(TaskOutcome.FROM_CACHE, secondRun.task(":generateBuildConfig")?.outcome)
80+
assertEquals(TaskOutcome.FROM_CACHE, secondRun.task(":generateBuildConfigClasses")?.outcome)
8181
}
8282

8383
@Test
8484
fun `using kotlin, cacheability should succeeded`() {
8585
buildScript.appendText("buildConfig.useKotlinOutput()\n")
8686

8787
val firstRun = runner.build()
88-
assertEquals(TaskOutcome.SUCCESS, firstRun.task(":generateBuildConfig")?.outcome)
88+
assertEquals(TaskOutcome.SUCCESS, firstRun.task(":generateBuildConfigClasses")?.outcome)
8989

9090
val secondRun = runner.build()
91-
assertEquals(TaskOutcome.FROM_CACHE, secondRun.task(":generateBuildConfig")?.outcome)
91+
assertEquals(TaskOutcome.FROM_CACHE, secondRun.task(":generateBuildConfigClasses")?.outcome)
9292

9393
buildScript.appendText("buildConfig.useKotlinOutput { topLevelConstants = true }\n")
9494

9595
val thirdRun = runner.build()
96-
assertEquals(TaskOutcome.SUCCESS, thirdRun.task(":generateBuildConfig")?.outcome)
96+
assertEquals(TaskOutcome.SUCCESS, thirdRun.task(":generateBuildConfigClasses")?.outcome)
9797
}
9898

9999
}

0 commit comments

Comments
 (0)