Fix, added check to make sure the owner node knows the new node

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>

Author: hanxizh9910

tests/support/cluster_util.tcl

@@ -459,13 +459,12 @@ proc wait_for_slot_state {srv_idx pattern} {
     }
 }
 
-# Check if server_a knows node_b_id
-proc server_knows_node {server_a node_b_id} {
-    set nodes [get_cluster_nodes $server_a]
-    foreach n $nodes {
-        if {[dict get $n id] eq $node_b_id} {
-            return 1
+# Returns the test index of a node given its node ID
+proc get_node_index_by_id {node_id} {
+    for {set i 0} {$i < [llength $::servers]} {incr i} {
+        if {[R $i CLUSTER MYID] eq $node_id} {
+            return $i
         }
     }
-    return 0
+    return -1  ;# not found
 }

tests/unit/cluster/cli.tcl

@@ -295,15 +295,13 @@ test {Migrate the last slot away from a node using valkey-cli} {
         set owner_r [valkey $owner_host $owner_port 0 $::tls]
         set owner_id [$owner_r CLUSTER MYID]
 
-        # Wait until owner node knows the new node
+        # get the index of the owner node
+        set owner_index [get_node_index_by_id $owner_id]
+
         wait_for_condition 1000 50 {
-            set found 0
-            foreach n [get_cluster_nodes $owner_id] {
-                if {[dict get $n id] eq $newnode_id} { set found 1; break }
-            }
-            $found
+            [cluster_get_node_by_id $owner_index $newnode_id] ne {}
         } else {
-            fail "Owner node does not know the new node yet"
+            fail "Owner node never learned the new node"
         }
 
         # Move slot to new node using plain commands