Add automated test failure detection and issue creation

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>

Author: hanxizh9910

.config/typos.toml

@@ -71,6 +71,3 @@ ake = "ake"
 [type.tcl.extend-words]
 fo = "fo"
 tre = "tre"
-
-[type.cpp.extend-words]
-fo = "fo"

.github/actions/upload-test-failures/action.yml

@@ -0,0 +1,16 @@
+name: 'Upload Test Failures'
+description: 'Upload test-failures.json as artifact'
+inputs:
+  job-name:
+    description: 'Unique name for the artifact'
+    required: true
+runs:
+  using: 'composite'
+  steps:
+    - name: Upload test failures
+      uses: actions/upload-artifact@v4
+      with:
+        name: test-failures-${{ inputs.job-name }}
+        path: test-failures.json
+        if-no-files-found: ignore
+        retention-days: 7

.github/instructions/core-engine.instructions.md

@@ -36,7 +36,7 @@ Apply these standards to core engine C code. Do NOT apply to `deps/` (vendored d
 - **PR Scope:** Separate refactoring from functional changes for easier backporting.
 
 ## 5. Testing & Documentation
-- **Unit Tests:** Required for data structures in `src/unit/`. Test files should follow `test_*.cpp` naming.
+- **Unit Tests:** Required for data structures in `src/unit/`. Test files should follow `test_*.c` naming.
 - **Integration Tests:** Required for commands in `tests/`.
 - **Command Changes:** New/modified commands need corresponding updates in `src/commands/*.json`.
 - **New C Files:** Remind to update `CMakeLists.txt` when adding new `.c` source files.

.github/scripts/extract_failures.py

@@ -0,0 +1,28 @@
+import re
+import json
+
+
+def parse_failure_entry(entry, job_name="unknown"):
+    """
+    Parse a raw failure string from the test runner.
+    """
+    m = re.match(
+        r'\[(\w+)\]:\s*(.+?)\s+in\s+(tests/\S+\.tcl)\s*\n?(.*)',
+        entry,
+        re.DOTALL
+    )
+    if m:
+        return {
+            "test_name": m.group(2).strip(),
+            "test_file": m.group(3).strip(),
+            "error": m.group(4).strip(),
+            "job": job_name,
+        }
+
+    # Fallback: couldn't parse, return raw
+    return {
+        "test_name": entry[:100],
+        "test_file": "unknown",
+        "error": entry,
+        "job": job_name,
+    }

.github/workflows/ci.yml

@@ -35,9 +35,7 @@ jobs:
       - name: make
         # Fail build if there are warnings
         # build with TLS just for compilation coverage
-        run: |
-          sudo apt-get install pkg-config libgtest-dev libgmock-dev
-          make -j4 all-with-unit-tests SERVER_CFLAGS='-Werror' BUILD_TLS=yes USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes
+        run: make -j4 all-with-unit-tests SERVER_CFLAGS='-Werror' BUILD_TLS=yes USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes
       - name: test
         run: |
           sudo apt-get install tcl8.6 tclx
@@ -52,7 +50,7 @@ jobs:
           if [[ ! -z "$dirty" ]]; then echo "$dirty"; exit 1; fi
       - name: unit tests
         run: |
-          ./src/unit/valkey-unit-gtests
+          ./src/valkey-unit-tests
 
   test-ubuntu-latest-compatibility:
     runs-on: ubuntu-latest
@@ -64,9 +62,6 @@ jobs:
           - {version: "8.0.6", file: "valkey-8.0.6-noble-x86_64.tar.gz"}
           - {version: "8.1.4", file: "valkey-8.1.4-noble-x86_64.tar.gz"}
     steps:
-      - name: Install gtest
-        run: |
-          sudo apt-get install pkg-config libgtest-dev libgmock-dev
       - name: Install libbacktrace
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
@@ -108,7 +103,7 @@ jobs:
           sudo apt-get install -y cmake libssl-dev
           mkdir -p build-release
           cd build-release
-          cmake -DCMAKE_BUILD_TYPE=Release .. -DBUILD_TLS=yes -DBUILD_UNIT_GTESTS=yes
+          cmake -DCMAKE_BUILD_TYPE=Release .. -DBUILD_TLS=yes -DBUILD_UNIT_TESTS=yes
           make -j$(nproc)
       - name: test
         run: |
@@ -117,7 +112,7 @@ jobs:
           ./build-release/runtest --verbose --tags -slow --dump-logs --tls
       - name: unit tests
         run: |
-          ./build-release/bin/valkey-unit-gtests
+          ./build-release/bin/valkey-unit-tests
 
   test-sanitizer-address:
     runs-on: ubuntu-latest
@@ -133,18 +128,15 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - name: make
         # build with TLS module just for compilation coverage
-        run: |
-          sudo apt-get install pkg-config libgtest-dev libgmock-dev
-          make -j4 all-with-unit-tests SANITIZER=address SERVER_CFLAGS='-Werror' BUILD_TLS=module USE_LIBBACKTRACE=yes
+        run: make -j4 all-with-unit-tests SANITIZER=address SERVER_CFLAGS='-Werror' BUILD_TLS=module USE_LIBBACKTRACE=yes
       - name: testprep
         run: sudo apt-get install tcl8.6 tclx -y
       - name: test
         run: ./runtest --verbose --tags -slow --dump-logs
       - name: module api test
         run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs
       - name: unit tests
-        run: |
-          ./src/unit/valkey-unit-gtests
+        run: ./src/valkey-unit-tests
 
   test-rdma:
     runs-on: ubuntu-latest
@@ -228,15 +220,9 @@ jobs:
       - run: cd libbacktrace && ./configure && make && sudo make install
       - name: Checkout Valkey
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - name: Install build dependencies
-        run: brew install llvm googletest
       - name: make
         # Build with additional upcoming features
-        run: |
-          export PATH="/opt/homebrew/opt/llvm/bin:$PATH"
-          export CC=/opt/homebrew/opt/llvm/bin/clang
-          export CXX=/opt/homebrew/opt/llvm/bin/clang++
-          make -j3 all-with-unit-tests SERVER_CFLAGS='-Werror' USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes LIBBACKTRACE_PREFIX=/usr/local
+        run: make -j3 all-with-unit-tests SERVER_CFLAGS='-Werror' USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes
 
   build-32bit:
     runs-on: ubuntu-latest
@@ -254,34 +240,16 @@ jobs:
           cd libbacktrace && ./configure CFLAGS="-m32" --prefix=/usr/local/libbacktrace32 && make && sudo make install
       - name: Checkout Valkey
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-      - name: Install gtest
-        run: |
-          sudo apt-get update
-          sudo apt-get install libgtest-dev
-          mkdir -p /tmp/gtest32
-          cd /tmp/gtest32
-          cmake -B build32 \
-              -DCMAKE_BUILD_TYPE=Release \
-              -DCMAKE_C_FLAGS="-m32" \
-              -DCMAKE_CXX_FLAGS="-m32" \
-              -DCMAKE_EXE_LINKER_FLAGS="-m32" \
-              /usr/src/googletest
-          cmake --build build32 --parallel
-          sudo cp build32/lib/*.a /usr/lib32/
-          cd $GITHUB_WORKSPACE
       - name: make
         # Fast float requires C++ 32-bit libraries to compile on 64-bit ubuntu
         # machine i.e. "-cross" suffixed version. Cross-compiling c++ to 32-bit
         # also requires multilib support for g++ compiler i.e. "-multilib"
         # suffixed version of g++. g++-multilib generally includes libstdc++.
         # *cross version as well, but it is also added explicitly just in case.
-        run: |
-          make -j4 SERVER_CFLAGS='-Werror' 32bit USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes LIBBACKTRACE_PREFIX=/usr/local/libbacktrace32 \
-            GTEST_CFLAGS="-I/usr/src/googletest/googletest/include -I/usr/src/googletest/googlemock/include" \
-            GTEST_LIBS="/usr/lib32/libgtest.a /usr/lib32/libgmock.a"
+        run: make -j4 SERVER_CFLAGS='-Werror' 32bit USE_FAST_FLOAT=yes USE_LIBBACKTRACE=yes LIBBACKTRACE_PREFIX=/usr/local/libbacktrace32
       - name: unit tests
         run: |
-          ./src/unit/valkey-unit-gtests
+          ./src/valkey-unit-tests
 
   build-libc-malloc:
     runs-on: ubuntu-latest
@@ -310,7 +278,7 @@ jobs:
           path: libbacktrace
       - name: Build libbacktrace
         run: |
-          dnf -y install epel-release gcc gcc-c++ make procps-ng which git cmake
+          dnf -y install epel-release gcc gcc-c++ make procps-ng which
           cd libbacktrace && ./configure && make && make install
       - name: Checkout Valkey
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/clang-format.yml

@@ -1,8 +1,5 @@
 name: Clang Format Check
 
-permissions:
-  contents: read
-
 on:
   push:
     paths-ignore:
@@ -42,7 +39,7 @@ jobs:
           # Run clang-format and capture the diff
           cd src
           shopt -s globstar
-          clang-format-18 -i **/*.c **/*.h **/*.cpp **/*.hpp
+          clang-format-18 -i **/*.c **/*.h
           # Capture the diff output
           DIFF=$(git diff)
           if [ ! -z "$DIFF" ]; then

.github/workflows/codecov.yml

@@ -1,8 +1,5 @@
 name: "Codecov"
 
-permissions:
-  contents: read
-
 # Enabling on each push is to display the coverage changes in every PR, 
 # where each PR needs to be compared against the coverage of the head commit
 on:
@@ -44,4 +41,4 @@ jobs:
         uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./src/valkey.info
+          file: ./src/valkey.info

.github/workflows/codeql-analysis.yml

@@ -40,12 +40,12 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
+        uses: github/codeql-action/init@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2
         with:
           languages: ${{ matrix.language }}
 
       - name: Autobuild
-        uses: github/codeql-action/autobuild@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
+        uses: github/codeql-action/autobuild@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@c793b717bc78562f491db7b0e93a3a178b099162 # v4.32.5
+        uses: github/codeql-action/analyze@b5ebac6f4c00c8ccddb7cdcd45fdb248329f808a # v3.32.2