Skip to content

Commit 6fbd86f

Browse files
hanxizh9910hanxizh9910
committed
Comment two test-jobs which take the longest time
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
1 parent 768c79e commit 6fbd86f

1 file changed

Lines changed: 106 additions & 106 deletions

File tree

‎.github/workflows/daily.yml‎

Lines changed: 106 additions & 106 deletions
Original file line numberDiff line numberDiff line change
@@ -600,108 +600,108 @@ jobs:
600600
uses: ./.github/actions/upload-test-failures
601601
with:
602602
job-name: ${{ github.job }}
603-
test-ubuntu-io-threads:
604-
runs-on: ubuntu-latest
605-
if: |
606-
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
607-
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
608-
(github.event_name == 'pull_request' &&
609-
(github.event.pull_request.base.ref != 'unstable' ||
610-
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
611-
(github.event.action != 'labeled' ||
612-
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
613-
)) &&
614-
!contains(github.event.inputs.skipjobs, 'iothreads')
615-
timeout-minutes: 1440
616-
steps:
617-
- name: prep
618-
if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
619-
run: |
620-
echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
621-
echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
622-
echo "skipjobs: ${{github.event.inputs.skipjobs}}"
623-
echo "skiptests: ${{github.event.inputs.skiptests}}"
624-
echo "test_args: ${{github.event.inputs.test_args}}"
625-
echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
626-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
627-
with:
628-
repository: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_repo || github.event.inputs.use_repo)) || github.repository }}
629-
ref: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_git_ref || github.event.inputs.use_git_ref)) || github.ref }}
630-
- name: Install libbacktrace
631-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
632-
with:
633-
repository: ianlancetaylor/libbacktrace
634-
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
635-
path: libbacktrace
636-
- run: cd libbacktrace && ./configure && make && sudo make install
637-
- name: make
638-
run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
639-
- name: testprep
640-
run: sudo apt-get install tcl8.6 tclx
641-
- name: test
642-
if: true && !contains(github.event.inputs.skiptests, 'valkey')
643-
run: ./runtest --io-threads --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
644-
- name: cluster tests
645-
if: true && !contains(github.event.inputs.skiptests, 'cluster')
646-
run: ./runtest-cluster --failures-json test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}}
647-
- name: Upload test failures
648-
if: always()
649-
uses: ./.github/actions/upload-test-failures
650-
with:
651-
job-name: ${{ github.job }}
652-
test-ubuntu-tls-io-threads:
653-
runs-on: ubuntu-latest
654-
if: |
655-
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
656-
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
657-
(github.event_name == 'pull_request' &&
658-
(github.event.pull_request.base.ref != 'unstable' ||
659-
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
660-
(github.event.action != 'labeled' ||
661-
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
662-
)) &&
663-
!contains(github.event.inputs.skipjobs, 'tls') && !contains(github.event.inputs.skipjobs, 'iothreads')
664-
timeout-minutes: 1440
665-
steps:
666-
- name: prep
667-
if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
668-
run: |
669-
echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
670-
echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
671-
echo "skipjobs: ${{github.event.inputs.skipjobs}}"
672-
echo "skiptests: ${{github.event.inputs.skiptests}}"
673-
echo "test_args: ${{github.event.inputs.test_args}}"
674-
echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
675-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
676-
with:
677-
repository: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_repo || github.event.inputs.use_repo)) || github.repository }}
678-
ref: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_git_ref || github.event.inputs.use_git_ref)) || github.ref }}
679-
- name: Install libbacktrace
680-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
681-
with:
682-
repository: ianlancetaylor/libbacktrace
683-
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
684-
path: libbacktrace
685-
- run: cd libbacktrace && ./configure && make && sudo make install
686-
- name: make
687-
run: make BUILD_TLS=yes SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
688-
- name: testprep
689-
run: |
690-
sudo apt-get install tcl8.6 tclx tcl-tls
691-
./utils/gen-test-certs.sh
692-
- name: test
693-
if: true && !contains(github.event.inputs.skiptests, 'valkey')
694-
run: |
695-
./runtest --io-threads --tls --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
696-
- name: cluster tests
697-
if: true && !contains(github.event.inputs.skiptests, 'cluster')
698-
run: |
699-
./runtest-cluster --failures-json test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}}
700-
- name: Upload test failures
701-
if: always()
702-
uses: ./.github/actions/upload-test-failures
703-
with:
704-
job-name: ${{ github.job }}
603+
# test-ubuntu-io-threads:
604+
# runs-on: ubuntu-latest
605+
# if: |
606+
# (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
607+
# (github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
608+
# (github.event_name == 'pull_request' &&
609+
# (github.event.pull_request.base.ref != 'unstable' ||
610+
# contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
611+
# (github.event.action != 'labeled' ||
612+
# (github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
613+
# )) &&
614+
# !contains(github.event.inputs.skipjobs, 'iothreads')
615+
# timeout-minutes: 1440
616+
# steps:
617+
# - name: prep
618+
# if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
619+
# run: |
620+
# echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
621+
# echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
622+
# echo "skipjobs: ${{github.event.inputs.skipjobs}}"
623+
# echo "skiptests: ${{github.event.inputs.skiptests}}"
624+
# echo "test_args: ${{github.event.inputs.test_args}}"
625+
# echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
626+
# - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
627+
# with:
628+
# repository: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_repo || github.event.inputs.use_repo)) || github.repository }}
629+
# ref: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_git_ref || github.event.inputs.use_git_ref)) || github.ref }}
630+
# - name: Install libbacktrace
631+
# uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
632+
# with:
633+
# repository: ianlancetaylor/libbacktrace
634+
# ref: b9e40069c0b47a722286b94eb5231f7f05c08713
635+
# path: libbacktrace
636+
# - run: cd libbacktrace && ./configure && make && sudo make install
637+
# - name: make
638+
# run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
639+
# - name: testprep
640+
# run: sudo apt-get install tcl8.6 tclx
641+
# - name: test
642+
# if: true && !contains(github.event.inputs.skiptests, 'valkey')
643+
# run: ./runtest --io-threads --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
644+
# - name: cluster tests
645+
# if: true && !contains(github.event.inputs.skiptests, 'cluster')
646+
# run: ./runtest-cluster --failures-json test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}}
647+
# - name: Upload test failures
648+
# if: always()
649+
# uses: ./.github/actions/upload-test-failures
650+
# with:
651+
# job-name: ${{ github.job }}
652+
# test-ubuntu-tls-io-threads:
653+
# runs-on: ubuntu-latest
654+
# if: |
655+
# (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
656+
# (github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
657+
# (github.event_name == 'pull_request' &&
658+
# (github.event.pull_request.base.ref != 'unstable' ||
659+
# contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
660+
# (github.event.action != 'labeled' ||
661+
# (github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
662+
# )) &&
663+
# !contains(github.event.inputs.skipjobs, 'tls') && !contains(github.event.inputs.skipjobs, 'iothreads')
664+
# timeout-minutes: 1440
665+
# steps:
666+
# - name: prep
667+
# if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
668+
# run: |
669+
# echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
670+
# echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
671+
# echo "skipjobs: ${{github.event.inputs.skipjobs}}"
672+
# echo "skiptests: ${{github.event.inputs.skiptests}}"
673+
# echo "test_args: ${{github.event.inputs.test_args}}"
674+
# echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
675+
# - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
676+
# with:
677+
# repository: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_repo || github.event.inputs.use_repo)) || github.repository }}
678+
# ref: ${{ ((github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call') && (inputs.use_git_ref || github.event.inputs.use_git_ref)) || github.ref }}
679+
# - name: Install libbacktrace
680+
# uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
681+
# with:
682+
# repository: ianlancetaylor/libbacktrace
683+
# ref: b9e40069c0b47a722286b94eb5231f7f05c08713
684+
# path: libbacktrace
685+
# - run: cd libbacktrace && ./configure && make && sudo make install
686+
# - name: make
687+
# run: make BUILD_TLS=yes SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
688+
# - name: testprep
689+
# run: |
690+
# sudo apt-get install tcl8.6 tclx tcl-tls
691+
# ./utils/gen-test-certs.sh
692+
# - name: test
693+
# if: true && !contains(github.event.inputs.skiptests, 'valkey')
694+
# run: |
695+
# ./runtest --io-threads --tls --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
696+
# - name: cluster tests
697+
# if: true && !contains(github.event.inputs.skiptests, 'cluster')
698+
# run: |
699+
# ./runtest-cluster --failures-json test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}}
700+
# - name: Upload test failures
701+
# if: always()
702+
# uses: ./.github/actions/upload-test-failures
703+
# with:
704+
# job-name: ${{ github.job }}
705705
test-ubuntu-reclaim-cache:
706706
runs-on: ubuntu-latest
707707
if: |
@@ -1977,8 +1977,8 @@ jobs:
19771977
- test-ubuntu-32bit
19781978
- test-ubuntu-tls
19791979
- test-ubuntu-tls-no-tls
1980-
- test-ubuntu-io-threads
1981-
- test-ubuntu-tls-io-threads
1980+
# - test-ubuntu-io-threads
1981+
# - test-ubuntu-tls-io-threads
19821982
- test-ubuntu-reclaim-cache
19831983
- test-valgrind-test
19841984
- test-valgrind-misc
@@ -2079,8 +2079,8 @@ jobs:
20792079
- test-ubuntu-32bit
20802080
- test-ubuntu-tls
20812081
- test-ubuntu-tls-no-tls
2082-
- test-ubuntu-io-threads
2083-
- test-ubuntu-tls-io-threads
2082+
# - test-ubuntu-io-threads
2083+
# - test-ubuntu-tls-io-threads
20842084
- test-ubuntu-reclaim-cache
20852085
- test-valgrind-test
20862086
- test-valgrind-misc

0 commit comments

Comments
 (0)