Fix clang LTO build failure due to LLVM version mismatch

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>

Author: hanxizh9910

src/Makefile

@@ -141,12 +141,6 @@ FINAL_LDFLAGS=$(LDFLAGS) $(OPT) $(SERVER_LDFLAGS) $(DEBUG)
 FINAL_LIBS=-lm
 DEBUG=-g -ggdb
 
-# Use lld when linking with clang to avoid LLVM version mismatches
-# between clang and the system's gold plugin during LTO.
-ifeq (clang,$(CLANG))
-	FINAL_LDFLAGS+=-fuse-ld=lld
-endif
-
 # Linux ARM32 needs -latomic at linking time
 ifneq (,$(findstring armv,$(uname_M)))
         FINAL_LIBS+=-latomic
@@ -740,9 +734,14 @@ $(TLS_MODULE_NAME): $(SERVER_NAME)
 $(RDMA_MODULE_NAME): $(SERVER_NAME)
 	$(QUIET_CC)$(CC) $(LDFLAGS) -o $@ rdma.c -shared -fPIC $(RDMA_MODULE_CFLAGS)
 
+# Strip -flto from OPTIMIZATION for the static Lua module build.
+# When archiving into a .a, LTO bitcode objects cause linker failures
+# if the system's LLVM gold plugin version doesn't match clang's version.
+LUA_MODULE_OPTIMIZATION=$(subst -flto,,$(OPTIMIZATION))
+
 # engine_lua.so
 $(LUA_MODULE_NAME): .make-prerequisites
-	$(MAKE) -C modules/lua OPTIMIZATION="$(OPTIMIZATION)" BUILD_LUA="$(BUILD_LUA)"
+	$(MAKE) -C modules/lua OPTIMIZATION="$(LUA_MODULE_OPTIMIZATION)" BUILD_LUA="$(BUILD_LUA)"
 
 # valkey-cli
 $(ENGINE_CLI_NAME): $(ENGINE_CLI_OBJ)

src/modules/lua/Makefile

@@ -32,8 +32,6 @@ QUIET_LINK_MOD = @printf '    %b %b\n' $(LINKCOLOR_MOD)LINK$(RESET) $(BINCOLOR_M
 endif
 ifeq (clang,$(CLANG))
 	SHOBJ_LDFLAGS+= -fuse-ld=lld
-	# Use llvm-ar for LTO bitcode compatibility when archiving with clang.
-	AR=llvm-ar
 endif
 
 endif