Skip to content

Commit a974838

Browse files
committed
Added calling module api test in the job, and fixed the consolidation condition
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
1 parent a2ac6e3 commit a974838

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/daily.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1931,6 +1931,11 @@ jobs:
19311931
- name: module api test
19321932
if: true && !contains(github.event.inputs.skiptests, 'modules')
19331933
run: CFLAGS='-Werror' ./runtest-moduleapi --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs ${{github.event.inputs.test_args}}
1934+
- name: Upload module api test failures
1935+
if: always() && !contains(github.event.inputs.skiptests, 'modules') && steps.module-api-test.outcome != 'skipped'
1936+
uses: ./.github/actions/upload-test-failures
1937+
with:
1938+
job-name: ${{ github.job }}-moduleapi
19341939
- name: sentinel tests
19351940
if: true && !contains(github.event.inputs.skiptests, 'sentinel')
19361941
run: ./runtest-sentinel --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}}
@@ -1945,7 +1950,7 @@ jobs:
19451950
run: ./utils/req-res-log-validator.py --verbose --fail-missing-reply-schemas ${{ (!contains(github.event.inputs.skiptests, 'valkey') && !contains(github.event.inputs.skiptests, 'module') && !contains(github.event.inputs.skiptests, 'sentinel') && !contains(github.event.inputs.skiptests, 'cluster')) && (inputs.test_args || github.event.inputs.test_args || '') == '' && (inputs.cluster_test_args || github.event.inputs.cluster_test_args || '') == '' && '--fail-commands-not-all-hit' || '' }}
19461951
consolidate-test-failures:
19471952
runs-on: ubuntu-latest
1948-
if: always() && !contains(github.event.inputs.skiptests, 'valkey')
1953+
if: always()
19491954
permissions:
19501955
actions: write
19511956
needs:

0 commit comments

Comments
 (0)