diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index ce6d7ff3af8..26bae23f0c0 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -118,16 +118,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -209,16 +209,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -279,16 +279,16 @@ jobs: run: apt-get install -y tcl8.6 tclx procps - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -342,16 +342,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -397,16 +397,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -473,18 +473,18 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') run: | make -C tests/modules 32bit # the script below doesn't have an argument, we must build manually ahead of time - CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -541,19 +541,19 @@ jobs: - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') run: | - ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs --tls ${{github.event.inputs.test_args}} + ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs --tls ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') run: | - CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs --tls ${{github.event.inputs.test_args}} + CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs --tls ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') run: | - ./runtest-sentinel --failures-json test-failures/sentinel.json --tls ${{github.event.inputs.cluster_test_args}} + ./runtest-sentinel --failures-output test-failures/sentinel.json --tls ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: | - ./runtest-cluster --failures-json test-failures/cluster.json --tls ${{github.event.inputs.cluster_test_args}} + ./runtest-cluster --failures-output test-failures/cluster.json --tls ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -602,19 +602,19 @@ jobs: - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') run: | - ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') run: | - CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') run: | - ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: | - ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -660,10 +660,10 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --io-threads --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --io-threads --accurate --failures-output test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -712,11 +712,11 @@ jobs: - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') run: | - ./runtest --io-threads --tls --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}} + ./runtest --io-threads --tls --accurate --failures-output test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: | - ./runtest-cluster --failures-json test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}} + ./runtest-cluster --failures-output test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -848,7 +848,7 @@ jobs: sudo apt-get install tcl8.6 tclx valgrind -y - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --valgrind --no-latency --failures-json test-failures/valkey.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --valgrind --no-latency --failures-output test-failures/valkey.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -893,7 +893,7 @@ jobs: sudo apt-get install tcl8.6 tclx valgrind -y - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --valgrind --no-latency --failures-json test-failures/moduleapi.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --valgrind --no-latency --failures-output test-failures/moduleapi.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -946,7 +946,7 @@ jobs: sudo apt-get install tcl8.6 tclx valgrind -y - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --valgrind --no-latency --failures-json test-failures/valkey.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --valgrind --no-latency --failures-output test-failures/valkey.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -991,7 +991,7 @@ jobs: sudo apt-get install tcl8.6 tclx valgrind -y - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --valgrind --no-latency --failures-json test-failures/moduleapi.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --valgrind --no-latency --failures-output test-failures/moduleapi.json --verbose --clients 1 --timeout 2400 --dump-logs ${{github.event.inputs.test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -1052,16 +1052,16 @@ jobs: sudo apt-get install tcl8.6 tclx -y - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -1136,10 +1136,10 @@ jobs: fi - name: large memory tests if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} + run: ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} - name: large memory module api tests if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} - name: Memory usage summary if: always() run: | @@ -1200,16 +1200,16 @@ jobs: sudo apt-get install tcl8.6 tclx -y - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -1284,10 +1284,10 @@ jobs: fi - name: large memory tests if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} + run: ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} - name: large memory module api tests if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs --clients 1 --large-memory --tags large-memory ${{github.event.inputs.test_args}} - name: Memory usage summary if: always() run: | @@ -1344,16 +1344,16 @@ jobs: sudo apt-get install tcl8.6 tclx -y - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | @@ -1410,16 +1410,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1490,16 +1490,16 @@ jobs: run: dnf -y install tcl tcltls - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1573,19 +1573,19 @@ jobs: - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') run: | - ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs --tls-module ${{github.event.inputs.test_args}} + ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs --tls-module ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') run: | - CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs --tls-module ${{github.event.inputs.test_args}} + CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs --tls-module ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') run: | - ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: | - ./runtest-cluster --failures-json test-failures/cluster.json --tls-module ${{github.event.inputs.cluster_test_args}} + ./runtest-cluster --failures-output test-failures/cluster.json --tls-module ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1654,19 +1654,19 @@ jobs: - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') run: | - ./runtest --accurate --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + ./runtest --accurate --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') run: | - CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') run: | - ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: | - ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1710,10 +1710,10 @@ jobs: run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1757,7 +1757,7 @@ jobs: run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1801,7 +1801,7 @@ jobs: run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1883,7 +1883,7 @@ jobs: run: | sudo pkg install -y bash gmake lang/tcl86 lang/tclX gmake - ./runtest --failures-json test-failures/valkey.json --single unit/keyspace --single unit/auth --single unit/networking --single unit/protocol + ./runtest --failures-output test-failures/valkey.json --single unit/keyspace --single unit/auth --single unit/networking --single unit/protocol - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1932,16 +1932,16 @@ jobs: run: apk add tcl procps tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -1990,16 +1990,16 @@ jobs: run: apk add tcl procps tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-json test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest ${{ github.event_name != 'pull_request' && '--accurate' || '' }} --failures-output test-failures/valkey.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json ${{github.event.inputs.cluster_test_args}} - name: Upload test failures if: always() uses: ./.github/actions/upload-test-failures @@ -2045,16 +2045,16 @@ jobs: run: sudo apt-get install tcl8.6 tclx - name: test if: true && !contains(github.event.inputs.skiptests, 'valkey') - run: ./runtest --failures-json test-failures/valkey.json --log-req-res --no-latency --dont-clean --force-resp3 --tags -slow --verbose --dump-logs ${{github.event.inputs.test_args}} + run: ./runtest --failures-output test-failures/valkey.json --log-req-res --no-latency --dont-clean --force-resp3 --tags -slow --verbose --dump-logs ${{github.event.inputs.test_args}} - name: module api test if: true && !contains(github.event.inputs.skiptests, 'modules') - run: CFLAGS='-Werror' ./runtest-moduleapi --failures-json test-failures/moduleapi.json --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs ${{github.event.inputs.test_args}} + run: CFLAGS='-Werror' ./runtest-moduleapi --failures-output test-failures/moduleapi.json --log-req-res --no-latency --dont-clean --force-resp3 --dont-pre-clean --verbose --dump-logs ${{github.event.inputs.test_args}} - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') - run: ./runtest-sentinel --failures-json test-failures/sentinel.json --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}} + run: ./runtest-sentinel --failures-output test-failures/sentinel.json --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}} - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') - run: ./runtest-cluster --failures-json test-failures/cluster.json --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}} + run: ./runtest-cluster --failures-output test-failures/cluster.json --log-req-res --dont-clean --force-resp3 ${{github.event.inputs.cluster_test_args}} - name: Install Python dependencies uses: py-actions/py-dependency-install@30aa0023464ed4b5b116bd9fbdab87acf01a484e # v4.1.0 with: diff --git a/tests/instances.tcl b/tests/instances.tcl index 22c21d121e7..b8a71e9fb33 100644 --- a/tests/instances.tcl +++ b/tests/instances.tcl @@ -24,7 +24,7 @@ set ::dont_clean 0 set ::simulate_error 0 set ::failed 0 set ::failed_tests {} -set ::failures_json_file "" +set ::failures_output_file "" set ::sentinel_instances {} set ::valkey_instances {} set ::global_config {} @@ -314,8 +314,8 @@ proc parse_options {} { set ::stop_on_failure 1 } elseif {$opt eq {--loop}} { set ::loop 1 - } elseif {$opt eq {--failures-json}} { - set ::failures_json_file [file normalize "../../../$val"] + } elseif {$opt eq {--failures-output}} { + set ::failures_output_file [file normalize "../../../$val"] incr j } elseif {$opt eq {--log-req-res}} { set ::log_req_res 1 @@ -335,7 +335,7 @@ proc parse_options {} { puts "--fast-fail Exit immediately once the first test fails." puts "--stop Blocks once the first test fails." puts "--loop Execute the specified set of tests forever." - puts "--failures-json Write test failures to the specified JSON file." + puts "--failures-output Write test failures to the specified JSON file." puts "--help Shows this help." exit 0 } else { @@ -529,7 +529,7 @@ while 1 { } proc write_test_failures {} { - if {$::failures_json_file eq ""} { + if {$::failures_output_file eq ""} { return } @@ -546,11 +546,11 @@ proc write_test_failures {} { lappend failures "\{\"test_name\":\"$test_name\",\"test_file\":\"$test_file\",\"status\":\"err\",\"error\":\"$error_msg\"\}" } - set outdir [file dirname $::failures_json_file] + set outdir [file dirname $::failures_output_file] if {$outdir ne "."} { file mkdir $outdir } - set fp [open $::failures_json_file w] + set fp [open $::failures_output_file w] puts $fp "\[[join $failures ","]\]" close $fp } diff --git a/tests/sentinel/tests/00-base.tcl b/tests/sentinel/tests/00-base.tcl index 97cc6540a96..a76e9cdbb47 100644 --- a/tests/sentinel/tests/00-base.tcl +++ b/tests/sentinel/tests/00-base.tcl @@ -46,7 +46,7 @@ test "SENTINEL MYID return the sentinel instance ID" { test "SENTINEL INFO CACHE returns the cached info" { set res [S 0 SENTINEL INFO-CACHE mymaster] assert_morethan_equal [llength $res] 2 - assert_equal "mymaster" [lindex $res 0] + assert_equal "mymasterr" [lindex $res 0] set res [lindex $res 1] assert_morethan_equal [llength $res] 2 diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl index c206e60186e..3dc0be158a7 100644 --- a/tests/test_helper.tcl +++ b/tests/test_helper.tcl @@ -73,7 +73,7 @@ set ::file ""; # If set, runs only the tests in this comma separated list set ::curfile ""; # Hold the filename of the current suite set ::accurate 0; # If true runs fuzz tests with more iterations set ::force_failure 0 -set ::failures_json_file ""; # If set, write failures JSON to this path +set ::failures_output_file ""; # If set, write failures JSON to this path set ::timeout 1200; # 20 minutes without progresses will quit the test. set ::last_progress [clock seconds] set ::active_servers {} ; # Pids of active server instances. @@ -612,7 +612,7 @@ proc print_test_summary {} { } proc write_test_failures {} { - if {$::failures_json_file eq ""} { + if {$::failures_output_file eq ""} { return } @@ -643,11 +643,11 @@ proc write_test_failures {} { lappend failures "\{\"test_name\":\"$test_name\",\"test_file\":\"$test_file\",\"status\":\"$status\",\"error\":\"$error_msg\"\}" } - set outdir [file dirname $::failures_json_file] + set outdir [file dirname $::failures_output_file] if {$outdir ne "."} { file mkdir $outdir } - set fp [open $::failures_json_file w] + set fp [open $::failures_output_file w] puts $fp "\[[join $failures ","]\]" close $fp } @@ -732,7 +732,7 @@ proc print_help_screen {} { "--clients Number of test clients (default 16)." "--timeout Test timeout in seconds (default 20 min)." "--force-failure Force the execution of a test that always fails." - "--failures-json " + "--failures-output " " Write test failures to the specified JSON file." "--config Extra config file argument." "--skipfile Name of a file containing test names or regexp patterns (if" @@ -857,8 +857,8 @@ for {set j 0} {$j < [llength $argv]} {incr j} { set ::accurate 1 } elseif {$opt eq {--force-failure}} { set ::force_failure 1 - } elseif {$opt eq {--failures-json}} { - set ::failures_json_file $arg + } elseif {$opt eq {--failures-output}} { + set ::failures_output_file $arg incr j } elseif {$opt eq {--single}} { foreach unit [expand_unit_spec $arg] { diff --git a/tests/unit/cluster/cli.tcl b/tests/unit/cluster/cli.tcl index 37fb84c05d1..7c11b67849f 100644 --- a/tests/unit/cluster/cli.tcl +++ b/tests/unit/cluster/cli.tcl @@ -24,7 +24,7 @@ start_multiple_servers 3 [list overrides $base_conf] { 127.0.0.1:[srv -2 port] wait_for_condition 1000 50 { - [CI 1 cluster_state] eq {ok} && + [CI 1 cluster_state] eq {okk} && [CI 2 cluster_state] eq {ok} } else { fail "Cluster doesn't stabilize" diff --git a/tests/unit/dummy-flaky.tcl b/tests/unit/dummy-flaky.tcl new file mode 100644 index 00000000000..b26a4d32eb0 --- /dev/null +++ b/tests/unit/dummy-flaky.tcl @@ -0,0 +1,17 @@ +start_server {tags {"dummy"}} { + test "dummy-flaky - basic SET and GET" { + r SET mykey myvalue + assert_equal [r GET mykey] "myvalue" + } + + test "dummy-flaky - intentional failure" { + r SET mykey myvalue + assert_equal [r GET mykey] "wrongvalue" + } + + test "dummy-flaky - another passing test" { + r SET counter 0 + r INCR counter + assert_equal [r GET counter] "1" + } +} diff --git a/tests/unit/moduleapi/auth.tcl b/tests/unit/moduleapi/auth.tcl index aae57535e3a..522b62b9cd9 100644 --- a/tests/unit/moduleapi/auth.tcl +++ b/tests/unit/moduleapi/auth.tcl @@ -14,7 +14,7 @@ start_server {tags {"modules"}} { # Verify returned id is the same as our current id and # we are authenticated with the specified user - assert_equal [r acl whoami] "global" + assert_equal [r acl whoami] "globall" } test {De-authenticating clients is tracked and kills clients} {