Skip to content

fix: skip credentials for public releases.jfrog.io downloads #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toller892 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: skip credentials for public releases.jfrog.io downloads #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions buildscripts/getFrogbot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,12 @@ echoGreetings() {
download_to() {
dl_url="$1"
dl_out="$2"
if [ -n "${JF_ACCESS_TOKEN:-}" ]; then
# Only use credentials when downloading from the user's own Artifactory
# (REMOTE_PATH is set when JF_RELEASES_REPO is configured).
# Public releases.jfrog.io downloads must not send user credentials.
if [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_ACCESS_TOKEN:-}" ]; then
curl -fLg -H "Authorization:Bearer ${JF_ACCESS_TOKEN}" -X GET "${dl_url}" -o "${dl_out}"
elif [ -n "${JF_USER:-}" ]; then
elif [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_USER:-}" ]; then
curl -fLg -u "${JF_USER}:${JF_PASSWORD:-}" -X GET "${dl_url}" -o "${dl_out}"
else
curl -fLg -X GET "${dl_url}" -o "${dl_out}"
Expand All @@ -117,9 +120,10 @@ download_to() {

head_request() {
dl_url="$1"
if [ -n "${JF_ACCESS_TOKEN:-}" ]; then
# Only use credentials when targeting the user's own Artifactory.
if [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_ACCESS_TOKEN:-}" ]; then
curl -sfILg -H "Authorization:Bearer ${JF_ACCESS_TOKEN}" "${dl_url}"
elif [ -n "${JF_USER:-}" ]; then
elif [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_USER:-}" ]; then
curl -sfILg -u "${JF_USER}:${JF_PASSWORD:-}" "${dl_url}"
else
curl -sfILg "${dl_url}"
Expand All @@ -142,9 +146,10 @@ artifact_url_to_storage_url() {

storage_request() {
local storage_url="$1"
if [ -n "${JF_ACCESS_TOKEN:-}" ]; then
# Only use credentials when targeting the user's own Artifactory.
if [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_ACCESS_TOKEN:-}" ]; then
curl -sfLg -H "Authorization:Bearer ${JF_ACCESS_TOKEN}" "${storage_url}"
elif [ -n "${JF_USER:-}" ]; then
elif [ -n "${REMOTE_PATH:-}" ] && [ -n "${JF_USER:-}" ]; then
curl -sfLg -u "${JF_USER}:${JF_PASSWORD:-}" "${storage_url}"
else
curl -sfLg "${storage_url}"
Expand Down
Loading