https://github.com/jfrog/jfrog-cli/pull/3441#top --> to loader.go#1346
Closed
Cesar-DC wants to merge 1 commit into
Closed
https://github.com/jfrog/jfrog-cli/pull/3441#top --> to loader.go#1346Cesar-DC wants to merge 1 commit into
Cesar-DC wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
recheck |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
RemiBou
reviewed
May 29, 2026
| @@ -45,7 +45,11 @@ func LoadCertificate(clientCertPath, clientCertKeyPath string) (certificate tls. | |||
|
|
|||
| func GetTransportWithLoadedCert(certificatesDirPath string, insecureTls bool, transport *http.Transport) (*http.Transport, error) { | |||
| // Remove once SystemCertPool supports windows | |||
Contributor
There was a problem hiding this comment.
you can remove the comment, can you implement some tests ?
RemiBou
added
the
safe to test
Contributor
|
@Cesar-DC as I dont have permission on your repo I'll chery pick your change on a cli branch and add test/clenaup comment and then merge, thx for the help |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for:
jfrog/jfrog-cli#3441 (comment)