fix(#832): fixed task-abort in model

In the task-processing of the models, the abort
was not handled correctly, which blocked the model
even from deletion.

Signed-off-by: Tobias Anker <tobias.anker@kitsunemimi.moe>

Author: kitsudaiki

src/binaries/sakura/src/api/http_endpoints/model/delete_model_internal_v1_0.rs

@@ -38,10 +38,6 @@ pub async fn delete_model_internal(
     model_uuid: Path<Uuid>,
     context: UserContext,
 ) -> Result<NoContent, ErrorResponse> {
-    // delete model from database
-    model_table::delete_model(&model_uuid, &context)
-        .map_err(|e| map_db_uuid_get_delete_error("model", &model_uuid, e))?;
-
     // delete model from core
     let mut model_handle = model_handler::CLUSTER_HANDLER
         .write()
@@ -50,5 +46,9 @@ pub async fn delete_model_internal(
         .delete_model(&model_uuid)
         .map_err(map_ainari_error_to_api_response)?;
 
+    // delete model from database
+    model_table::delete_model(&model_uuid, &context)
+        .map_err(|e| map_db_uuid_get_delete_error("model", &model_uuid, e))?;
+
     Ok(NoContent)
 }

src/binaries/sakura/src/core/processing/tasks.rs

@@ -177,7 +177,7 @@ impl Task {
     pub fn start_task(&mut self) -> bool {
         // check if task was aborted
         if task_table::is_aborted(&self.uuid) {
-            return true;
+            return false;
         }
 
         {
@@ -301,7 +301,7 @@ impl Task {
                 &(self.meta.number_of_finished_cycles as i64),
             );
             if task_table::is_aborted(&self.uuid) {
-                // TODO: handle abort correctly
+                self.meta.is_finished = true;
                 return;
             }
         }