Skip to content

Commit c59c2a6

Browse files
Update CONTRIBUTING file with PR review rules (#4452)
* Update CONTRIBUTING file with PR review rules Plus fixing some broken links. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refining based on the similar Porch instructions and comments from Copilot Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent db88451 commit c59c2a6

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

CONTRIBUTING.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,14 @@ All submissions, including submissions by project members, require review. We
5757
use GitHub pull requests for this purpose. Consult [GitHub Help] for more
5858
information on using pull requests.
5959

60+
Process for code reviews. Before requesting human review, a PR must:
61+
62+
* All tests passing
63+
* All linting passing
64+
* Meeting project code quality requirements, including passing all configured static analysis / SonarCloud quality gates and not reducing automated test coverage for the affected components
65+
* The comments from the first run of automatically generated comments (AI generated comments, SonarCloud comments, bot generated comments, etc.) of the PR are addressed (addressing further re-runs of AI are optional)
66+
* If it is not possible to resolve an automatic comment, please add a sub-comment indicating why the automated comment cannot be resolved or ask for help in resolving the comment
67+
6068
## Community Guidelines
6169

6270
This project follows a [Code of Conduct].
@@ -126,7 +134,7 @@ It's usually a good idea to test locally for the following:
126134

127135
#### Update docs
128136

129-
Docs are under [documentation/]. Refer to (the README,md)[documentation/README.md] in the folder to details about
137+
Docs are under [documentation/](documentation/). Refer to the [README.md](documentation/README.md) in the folder for details about
130138
documentation contributions.
131139

132140

0 commit comments

Comments
 (0)