Merge pull request #637 from lbedner/v0.6.11-rc3

v0.6.11-rc3

Author: lbedner

CLAUDE.md

@@ -32,7 +32,7 @@ Each generated project includes:
 
 ## Installation
 
-**Current Version**: 0.6.11rc2
+**Current Version**: 0.6.11rc3
 
 ```bash
 pip install aegis-stack
@@ -67,6 +67,34 @@ This project uses `uv` for dependency management and a `Makefile` for CLI develo
 
 **Template testing is critical** - always run `make test-template` after modifying templates to ensure generated projects work correctly.
 
+### Pre-RC verification (REQUIRED before any version bump)
+
+Before suggesting a version/rc bump, run BOTH locally:
+
+1. **`make check`** — the aegis-stack repo's OWN test suite (lint +
+   typecheck + pytest). Catches bugs in the CLI / core code itself,
+   including config tests that gate on constants like
+   ``DEFAULT_PYTHON_VERSION``. Without this, changing a constant
+   without updating its assertion test passes locally but fails CI.
+
+2. **`make test-stacks-full`** — the matrix that runs each generated
+   stack through generation → install → lint → typecheck → pytest.
+   Catches drift in templates / cross-stack issues.
+
+History shows multiple rcs in a row were "green locally" by `aegis init` +
+`make check` (on the GENERATED project) on a single stack, but failed CI
+because either:
+- The matrix was never run (caught template drift on stacks the local
+  test didn't generate), or
+- The aegis-stack repo's own tests were never run (caught constant /
+  config changes without test updates).
+
+Running both targets is the only way to match what CI actually runs.
+
+If the matrix takes too long during iteration, use `make test-stacks-quick`
+for fast feedback (3 representative stacks: base, everything, insights),
+then run the full matrix once at the end.
+
 ### TestPyPI Release Testing
 Test upgrade paths using TestPyPI before publishing to PyPI:
 

aegis/__init__.py

@@ -2,4 +2,4 @@
 Aegis Stack CLI - Component generation and project management tools.
 """
 
-__version__ = "0.6.11rc2"
+__version__ = "0.6.11rc3"

aegis/config/defaults.py

@@ -88,9 +88,16 @@ def _generate_supported_versions(min_version: str, max_version: str) -> list[str
 # Parse bounds from pyproject.toml (single source of truth)
 _min_version, _max_version = _parse_python_version_bounds()
 
-# Default Python version for generated projects (maximum supported)
-# Users can still specify --python-version 3.11 or 3.12 if desired
-DEFAULT_PYTHON_VERSION = _max_version
+# Default Python version for generated projects.
+#
+# Pinned to 3.13 (not the auto-derived max of 3.14) because the 3.14
+# ecosystem is still incomplete: openai 2.x has a circular import on
+# pytest collection under 3.14, and ``requests.compat`` is missing
+# ``JSONDecodeError``. Both break ``make check`` in matrix tests.
+# 3.13 has been out long enough that all our pinned deps work.
+# Users can still opt into 3.14 explicitly via ``--python-version 3.14``
+# (or 3.11 / 3.12 — anything in SUPPORTED_PYTHON_VERSIONS works).
+DEFAULT_PYTHON_VERSION = "3.13"
 
 # Supported Python versions (auto-generated from min to max)
 SUPPORTED_PYTHON_VERSIONS = _generate_supported_versions(_min_version, _max_version)

aegis/templates/copier-aegis-project/{{ project_slug }}/Makefile.jinja

@@ -129,7 +129,7 @@ lint: ## Check code style with ruff
 
 fix: ## Auto-fix linting and formatting issues
 	@echo "Auto-fixing code issues..."
-	@uv run ruff check . --fix
+	@-uv run ruff check . --fix
 	@uv run ruff format .
 
 format: ## Format code with ruff

aegis/templates/copier-aegis-project/{{ project_slug }}/app/cli/ai.py.jinja

@@ -391,7 +391,8 @@ def use_provider(
         existing_key = get_existing_api_key(provider)
 
         if not existing_key:
-            console.print(f"  [yellow]![/yellow] {t('ai.no_api_key_configured', var=env_var_name)}")
+            warning = t("ai.no_api_key_configured", var=env_var_name)
+            console.print(f"  [yellow]![/yellow] {warning}")
             console.print()
             console.print(f"[yellow]{t('ai.consider_running')}[/yellow]")
             console.print(
@@ -526,8 +527,8 @@ def chat(
             typer.echo("\nChat interrupted", err=True)
             raise typer.Exit(1)
         except Exception as e:
-            error_str = str(e)
 {% if ai_rag %}
+            error_str = str(e)
             # Provide helpful guidance for RAG collection errors
             if "No RAG collection specified" in error_str:
                 console.print()
@@ -649,7 +650,9 @@ def voice(
             # Validate file exists
             audio_path = Path(audio_file)
             if not audio_path.exists():
-                console.print(f"[red]{t('shared.error')}[/red] {t('ai.file_not_found', path=audio_file)}")
+                err_label = t("shared.error")
+                detail = t("ai.file_not_found", path=audio_file)
+                console.print(f"[red]{err_label}[/red] {detail}")
                 raise typer.Exit(1)
 
             # Determine audio format
@@ -658,7 +661,9 @@ def voice(
                 audio_format = AudioFormat(ext)
             except ValueError:
                 supported = ", ".join(f.value for f in AudioFormat)
-                console.print(f"[red]{t('shared.error')}[/red] {t('ai.unsupported_format', ext=ext)}")
+                err_label = t("shared.error")
+                detail = t("ai.unsupported_format", ext=ext)
+                console.print(f"[red]{err_label}[/red] {detail}")
                 console.print(f"[dim]{t('ai.supported_formats', formats=supported)}[/dim]")
                 raise typer.Exit(1)
 
@@ -704,11 +709,19 @@ def voice(
             console.print(f"  {result.transcription.text}")
 
             if result.transcription.language:
-                console.print(f"  [dim]{t('ai.language_label', lang=result.transcription.language)}[/dim]")
+                lang_label = t(
+                    "ai.language_label",
+                    lang=result.transcription.language,
+                )
+                console.print(f"  [dim]{lang_label}[/dim]")
             if result.transcription.duration_seconds:
-                console.print(
-                    f"  [dim]{t('ai.speech_duration', duration=f'{result.transcription.duration_seconds:.1f}')}[/dim]"
+                duration_str = (
+                    f"{result.transcription.duration_seconds:.1f}"
+                )
+                duration_label = t(
+                    "ai.speech_duration", duration=duration_str
                 )
+                console.print(f"  [dim]{duration_label}[/dim]")
 
             console.print()
             console.print(f"[bold green]{t('ai.response_label')}[/bold green]")
@@ -725,9 +738,11 @@ def voice(
 
             if result.conversation_id:
                 console.print()
-                console.print(
-                    f"[dim]{t('ai.conversation_id_label', id=result.conversation_id[:8])}...[/dim]"
+                conv_label = t(
+                    "ai.conversation_id_label",
+                    id=result.conversation_id[:8],
                 )
+                console.print(f"[dim]{conv_label}...[/dim]")
 
         except KeyboardInterrupt:
             typer.echo(f"\n{t('ai.cancelled')}", err=True)
@@ -794,7 +809,12 @@ def record(
             sample_rate = int(device_info['default_samplerate'])
             channels = 1  # Mono
 
-            console.print(f"[dim]{t('ai.using_mic', name=device_info['name'], rate=sample_rate)}[/dim]")
+            mic_label = t(
+                "ai.using_mic",
+                name=device_info["name"],
+                rate=sample_rate,
+            )
+            console.print(f"[dim]{mic_label}[/dim]")
 
             # Determine output path
             if output:
@@ -850,8 +870,11 @@ def record(
                         minutes = int(elapsed // 60)
                         seconds = int(elapsed % 60)
                         # Use regular print with \r for proper carriage return
+                        timer_str = (
+                            f"{minutes:02d}:{seconds:02d}"
+                        )
                         print(
-                            f"\r  \033[91m●\033[0m Recording: {minutes:02d}:{seconds:02d}",
+                            f"\r  \033[91m●\033[0m Recording: {timer_str}",
                             end="",
                             flush=True,
                         )
@@ -880,7 +903,13 @@ def record(
             # Save to WAV file
             sf.write(str(audio_path), audio_data, sample_rate)
 
-            console.print(f"[dim]{t('ai.audio_saved', path=str(audio_path), size=f'{audio_path.stat().st_size:,}')}[/dim]")
+            size_str = f"{audio_path.stat().st_size:,}"
+            saved_label = t(
+                "ai.audio_saved",
+                path=str(audio_path),
+                size=size_str,
+            )
+            console.print(f"[dim]{saved_label}[/dim]")
 
             # Read audio file
             with open(audio_path, "rb") as f:
@@ -949,9 +978,11 @@ def record(
 
                 if chat_result.metadata.get("conversation_id"):
                     console.print()
-                    console.print(
-                        f"[dim]{t('ai.conversation_id_label', id=chat_result.metadata['conversation_id'][:8])}...[/dim]"
+                    conv_label = t(
+                        "ai.conversation_id_label",
+                        id=chat_result.metadata["conversation_id"][:8],
                     )
+                    console.print(f"[dim]{conv_label}...[/dim]")
 
                 # Play TTS response if requested
                 if voice_response:
@@ -1047,7 +1078,9 @@ def transcribe(
             # Validate file exists
             audio_path = Path(audio_file)
             if not audio_path.exists():
-                console.print(f"[red]{t('shared.error')}[/red] {t('ai.file_not_found', path=audio_file)}")
+                err_label = t("shared.error")
+                detail = t("ai.file_not_found", path=audio_file)
+                console.print(f"[red]{err_label}[/red] {detail}")
                 raise typer.Exit(1)
 
             # Determine audio format
@@ -1056,7 +1089,9 @@ def transcribe(
                 audio_format = AudioFormat(ext)
             except ValueError:
                 supported = ", ".join(f.value for f in AudioFormat)
-                console.print(f"[red]{t('shared.error')}[/red] {t('ai.unsupported_format', ext=ext)}")
+                err_label = t("shared.error")
+                detail = t("ai.unsupported_format", ext=ext)
+                console.print(f"[red]{err_label}[/red] {detail}")
                 console.print(f"[dim]{t('ai.supported_formats', formats=supported)}[/dim]")
                 raise typer.Exit(1)
 
@@ -1208,7 +1243,11 @@ def speak(
             console.print(f"  [dim]{t('ai.speech_size', size=f'{len(result.audio):,}')}[/dim]")
 
             if result.duration_seconds:
-                console.print(f"  [dim]{t('ai.speech_duration', duration=f'{result.duration_seconds:.1f}')}[/dim]")
+                duration_str = f"{result.duration_seconds:.1f}"
+                duration_label = t(
+                    "ai.speech_duration", duration=duration_str
+                )
+                console.print(f"  [dim]{duration_label}[/dim]")
 
         except KeyboardInterrupt:
             typer.echo(f"\n{t('ai.cancelled')}", err=True)
@@ -1362,12 +1401,20 @@ def usage(
     # Display functions
     def display_summary_panel(stats: UsageStatsResponse) -> None:
         success_color = get_success_color(stats.success_rate)
+        tokens_label = t("ai.usage_total_tokens")
+        cost_label = t("ai.usage_total_cost")
+        requests_label = t("ai.usage_total_requests")
+        rate_label = t("ai.usage_success_rate")
+        tokens_str = format_number(stats.total_tokens)
+        cost_str = format_cost(stats.total_cost)
+        requests_str = format_number(stats.total_requests)
+        rate_str = format_percentage(stats.success_rate)
         summary_lines = [
-            f"[bold cyan]{t('ai.usage_total_tokens')}[/bold cyan]   {format_number(stats.total_tokens)}",
-            f"[bold cyan]{t('ai.usage_total_cost')}[/bold cyan]     {format_cost(stats.total_cost)}",
-            f"[bold cyan]{t('ai.usage_total_requests')}[/bold cyan] {format_number(stats.total_requests)}",
-            f"[bold cyan]{t('ai.usage_success_rate')}[/bold cyan]   "
-            f"[{success_color}]{format_percentage(stats.success_rate)}[/{success_color}]",
+            f"[bold cyan]{tokens_label}[/bold cyan]   {tokens_str}",
+            f"[bold cyan]{cost_label}[/bold cyan]     {cost_str}",
+            f"[bold cyan]{requests_label}[/bold cyan] {requests_str}",
+            f"[bold cyan]{rate_label}[/bold cyan]   "
+            f"[{success_color}]{rate_str}[/{success_color}]",
         ]
         console.print(
             Panel(
@@ -1388,8 +1435,14 @@ def usage(
         console.print(f"\n[bold blue]{t('ai.token_breakdown')}[/bold blue]")
         input_str = format_number(stats.input_tokens)
         output_str = format_number(stats.output_tokens)
-        console.print(f"  [cyan]{t('ai.input_tokens')}[/cyan]  {input_str:>12} ({input_pct:.0f}%)")
-        console.print(f"  [cyan]{t('ai.output_tokens')}[/cyan] {output_str:>12} ({output_pct:.0f}%)")
+        in_label = t("ai.input_tokens")
+        out_label = t("ai.output_tokens")
+        console.print(
+            f"  [cyan]{in_label}[/cyan]  {input_str:>12} ({input_pct:.0f}%)"
+        )
+        console.print(
+            f"  [cyan]{out_label}[/cyan] {output_str:>12} ({output_pct:.0f}%)"
+        )
         bar_width = 40
         input_bars = int((input_pct / 100) * bar_width)
         output_bars = bar_width - input_bars
@@ -1646,15 +1699,24 @@ async def _interactive_chat_session(
     ai_config = get_ai_config(settings)
 
     console.print()
-    console.print(f"[bold bright_magenta]Illiana[/bold bright_magenta] [dim]v{__aegis_version__}[/dim]")
+    banner = (
+        f"[bold bright_magenta]Illiana[/bold bright_magenta] "
+        f"[dim]v{__aegis_version__}[/dim]"
+    )
+    console.print(banner)
     console.print()
 
     # Boot steps with brief delays for effect
     console.print(f"  [dim]>[/dim] {t('ai.initializing')}", end="")
     await asyncio.sleep(0.15)
     console.print(f" [green]{t('ai.ok')}[/green]")
 
-    console.print(f"  [dim]>[/dim] {t('ai.connecting_to', provider=get_provider_display_name(ai_config.provider))}", end="")
+    provider_name = get_provider_display_name(ai_config.provider)
+    connecting_label = t("ai.connecting_to", provider=provider_name)
+    console.print(
+        f"  [dim]>[/dim] {connecting_label}",
+        end="",
+    )
     # Warm up the agent (lazy imports, model initialization)
     from app.services.ai.providers import get_agent
     _ = get_agent(ai_config, settings)
@@ -1694,7 +1756,12 @@ async def _interactive_chat_session(
             console.print(f"[green]{t('ai.health_ok', pct=health_pct)}[/green]")
         else:
             unhealthy_count = len(status.unhealthy_components)
-            console.print(f"[yellow]{t('ai.health_degraded', pct=health_pct, count=unhealthy_count)}[/yellow]")
+            degraded_label = t(
+                "ai.health_degraded",
+                pct=health_pct,
+                count=unhealthy_count,
+            )
+            console.print(f"[yellow]{degraded_label}[/yellow]")
     except Exception:
         console.print(f"[dim]{t('ai.health_na')}[/dim]")
 
@@ -1948,9 +2015,15 @@ async def _interactive_chat_session(
             except ProviderNotInstalledError as e:
                 # Clean display for missing provider
                 console.print()
-                console.print(f"[yellow]{t('ai.provider_not_installed', provider=e.provider)}[/yellow]")
+                missing_label = t(
+                    "ai.provider_not_installed", provider=e.provider
+                )
+                console.print(f"[yellow]{missing_label}[/yellow]")
                 console.print()
-                console.print(f"[green]{t('ai.run_to_install', command=e.cli_command)}[/green]")
+                install_label = t(
+                    "ai.run_to_install", command=e.cli_command
+                )
+                console.print(f"[green]{install_label}[/green]")
                 console.print()
             except Exception as stream_error:
                 console.print(f"[red]{t('shared.error')} {stream_error}[/red]")
@@ -2156,9 +2229,13 @@ async def _stream_chat_response(
     except ProviderNotInstalledError as e:
         # Clean display for missing provider - no need to re-raise
         console.print()
-        console.print(f"[yellow]{t('ai.provider_not_installed', provider=e.provider)}[/yellow]")
+        missing_label = t(
+            "ai.provider_not_installed", provider=e.provider
+        )
+        console.print(f"[yellow]{missing_label}[/yellow]")
         console.print()
-        console.print(f"[green]{t('ai.run_to_install', command=e.cli_command)}[/green]")
+        install_label = t("ai.run_to_install", command=e.cli_command)
+        console.print(f"[green]{install_label}[/green]")
         console.print()
         return None