Skip to content

Commit 9ec2e89

Browse files
author
leoding86
committed
close #289, don't listen onDeterminingFilename event
The issue of browser "save as" takes too long is persist when listen onDeterminingFilename event. It seems like the browser won't remove the listener on the event after profile closed. Need more investigation on this one.
1 parent 9277396 commit 9ec2e89

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/background/services/DownloadService.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class DownloadService extends AbstractService {
2424

2525
constructor() {
2626
super();
27-
this.listenOnDeterminingFilename();
27+
// this.listenOnDeterminingFilename();
2828
}
2929

3030
listenOnDeterminingFilename() {
@@ -131,7 +131,7 @@ class DownloadService extends AbstractService {
131131
}
132132

133133
async saveFile({ url, filename }) {
134-
this.cacheDownloadIdFilename(url, filename);
134+
// this.cacheDownloadIdFilename(url, filename);
135135
const downloadId = await FileSystem.getDefault().saveFile({ url, filename });
136136
return downloadId;
137137
}

0 commit comments

Comments
 (0)