Stabilize Electron release make checks

Author: wutongci

.github/workflows/release.yml

@@ -289,14 +289,24 @@ jobs:
           npx electron-forge package \
             --platform "${{ matrix.host_platform }}" \
             --arch "${{ matrix.arch }}"
-          set +e
-          npx electron-forge make \
-            --skip-package \
-            --platform "${{ matrix.host_platform }}" \
-            --arch "${{ matrix.arch }}" \
-            --targets "${{ matrix.forge_targets }}"
-          forge_status=$?
-          set -e
+          FORGE_MAKE_LOG="$RUNNER_TEMP/electron-forge-make-${{ matrix.host_platform }}-${{ matrix.arch }}.log"
+          run_forge_make() {
+            set +e
+            npx electron-forge make \
+              --skip-package \
+              --platform "${{ matrix.host_platform }}" \
+              --arch "${{ matrix.arch }}" \
+              --targets "${{ matrix.forge_targets }}" 2>&1 | tee "$FORGE_MAKE_LOG"
+            forge_status=${PIPESTATUS[0]}
+            set -e
+          }
+          run_forge_make
+          if [ "$forge_status" -ne 0 ] && [ "${{ matrix.host_platform }}" = "darwin" ] && grep -q "hdiutil detach /Volumes/Lime" "$FORGE_MAKE_LOG" && grep -q "No such file or directory" "$FORGE_MAKE_LOG"; then
+            echo "Electron Forge DMG cleanup hit a missing /Volumes/Lime mount; retrying make once after best-effort cleanup."
+            hdiutil detach "/Volumes/Lime" -force || true
+            sleep 5
+            run_forge_make
+          fi
           echo "Electron Forge output files:"
           if [ -d release-electron ]; then
             find release-electron -type f | sort

scripts/electron/current-entrypoints.test.mjs

@@ -262,6 +262,8 @@ describe("Electron current package entrypoints", () => {
     expect(smokeBuildRenderer).toContain("NODE_OPTIONS");
     expect(viteConfig).toContain("base:");
     expect(viteConfig).toContain('isElectronRenderer ? "./" : undefined');
+    expect(viteConfig).toContain('find: "app-server-client"');
+    expect(viteConfig).toContain("./packages/app-server-client/src/index.ts");
   });
 
   it("build monitor observes Electron package output instead of retired host bundles", () => {

scripts/electron/release-workflow-guard.mjs

@@ -297,10 +297,16 @@ function assertBuildSteps(buildJob) {
     "npm run electron:build",
     "npx electron-forge package",
     "npx electron-forge make",
+    "FORGE_MAKE_LOG",
+    "run_forge_make",
     "--skip-package",
     '--platform "${{ matrix.host_platform }}"',
     '--arch "${{ matrix.arch }}"',
     '--targets "${{ matrix.forge_targets }}"',
+    "PIPESTATUS[0]",
+    "hdiutil detach /Volumes/Lime",
+    "No such file or directory",
+    'hdiutil detach "/Volumes/Lime" -force || true',
     "find release-electron -type f | sort",
     "codesign --display --verbose=4",
     "codesign --verify --deep --strict --verbose=4",

scripts/electron/release-workflow-guard.test.mjs

@@ -129,6 +129,17 @@ describe("Electron release workflow guard", () => {
     );
   });
 
+  it("rejects missing macOS DMG detach retry guard in Forge make step", () => {
+    const current = fs.readFileSync(".github/workflows/release.yml", "utf8");
+    const workflowPath = tempWorkflowPath(
+      current.replaceAll("hdiutil detach /Volumes/Lime", "hdiutil detach"),
+    );
+
+    expect(() => validateReleaseWorkflow({ workflowPath })).toThrow(
+      /Electron Forge make step must include hdiutil detach \/Volumes\/Lime/,
+    );
+  });
+
   it("rejects missing Forge make asset scan", () => {
     const current = fs.readFileSync(".github/workflows/release.yml", "utf8");
     const workflowPath = tempWorkflowPath(

vite.config.ts

@@ -56,6 +56,13 @@ export default defineConfig(({ command, mode }) => {
           find: "@",
           replacement: path.resolve(__dirname, "./src"),
         },
+        {
+          find: "app-server-client",
+          replacement: path.resolve(
+            __dirname,
+            "./packages/app-server-client/src/index.ts",
+          ),
+        },
       ],
     },
     optimizeDeps: {