Skip to content

Commit bf75ba3

Browse files
committed
svc-selkies: honor SELKIES_MODE env var in run script
Selkies's argument parser declares a `mode` setting with `env_var: SELKIES_MODE` that selects between `websockets` (default) and `webrtc`. The s6 run script for svc-selkies hardcodes `--mode="websockets"` which overrides the env var and forces every container into websocket-mode regardless of the user's `-e SELKIES_MODE=webrtc` setting. Replace the hardcoded value with `${SELKIES_MODE:-websockets}` so the existing default is preserved while the documented env var actually takes effect. Both the production exec and the DEV_MODE branch are updated for consistency.
1 parent 1bdf561 commit bf75ba3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • root/etc/s6-overlay/s6-rc.d/svc-selkies

root/etc/s6-overlay/s6-rc.d/svc-selkies/run

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ if [ ! -z ${DEV_MODE+x} ]; then
5555
nodemon -V --ext py --exec \
5656
"python3" -m selkies \
5757
--addr="localhost" \
58-
--mode="websockets" \
58+
--mode="${SELKIES_MODE:-websockets}" \
5959
--debug="true"
6060
fi
6161

6262
# Start Selkies
6363
exec s6-setuidgid abc \
6464
selkies \
6565
--addr="localhost" \
66-
--mode="websockets"
66+
--mode="${SELKIES_MODE:-websockets}"

0 commit comments

Comments
 (0)