fix: improve sync_tools thread handling and update dependencies (#545)

Enhance thread management in `sync_tools` to improve performance and reliability.

Author: cofin

.pre-commit-config.yaml

@@ -22,7 +22,7 @@ repos:
       - id: unasyncd
         additional_dependencies: ["ruff"]
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.12.11"
+    rev: "v0.13.1"
     hooks:
       # Run the linter.
       - id: ruff

advanced_alchemy/alembic/commands.py

@@ -2,24 +2,25 @@
 import sys
 from typing import TYPE_CHECKING, Any, Optional, TextIO, Union
 
+from alembic.config import Config as _AlembicCommandConfig
+from alembic.ddl.impl import DefaultImpl
+
 from advanced_alchemy.config.asyncio import SQLAlchemyAsyncConfig
 from advanced_alchemy.exceptions import ImproperConfigurationError
 from alembic import command as migration_command
-from alembic.config import Config as _AlembicCommandConfig
-from alembic.ddl.impl import DefaultImpl
 
 if TYPE_CHECKING:
     import os
     from argparse import Namespace
     from collections.abc import Mapping
     from pathlib import Path
 
+    from alembic.runtime.environment import ProcessRevisionDirectiveFn
+    from alembic.script.base import Script
     from sqlalchemy import Engine
     from sqlalchemy.ext.asyncio import AsyncEngine
 
     from advanced_alchemy.config.sync import SQLAlchemySyncConfig
-    from alembic.runtime.environment import ProcessRevisionDirectiveFn
-    from alembic.script.base import Script
 
 
 class AlembicSpannerImpl(DefaultImpl):

advanced_alchemy/alembic/templates/asyncio/env.py

@@ -1,12 +1,12 @@
 import asyncio
 from typing import TYPE_CHECKING, cast
 
+from alembic.autogenerate import rewriter
 from sqlalchemy import pool
 from sqlalchemy.ext.asyncio import AsyncEngine, async_engine_from_config
 
 from advanced_alchemy.base import metadata_registry
 from alembic import context
-from alembic.autogenerate import rewriter
 
 if TYPE_CHECKING:
     from sqlalchemy.engine import Connection

advanced_alchemy/alembic/templates/sync/env.py

@@ -1,10 +1,10 @@
 from typing import TYPE_CHECKING, cast
 
+from alembic.autogenerate import rewriter
 from sqlalchemy import Engine, engine_from_config, pool
 
 from advanced_alchemy.base import metadata_registry
 from alembic import context
-from alembic.autogenerate import rewriter
 
 if TYPE_CHECKING:
     from sqlalchemy.engine import Connection

advanced_alchemy/cli.py

@@ -4,11 +4,11 @@
 from typing import TYPE_CHECKING, Optional, Union, cast
 
 if TYPE_CHECKING:
+    from alembic.migration import MigrationContext
+    from alembic.operations.ops import MigrationScript, UpgradeOps
     from click import Group
 
     from advanced_alchemy.config import SQLAlchemyAsyncConfig, SQLAlchemySyncConfig
-    from alembic.migration import MigrationContext
-    from alembic.operations.ops import MigrationScript, UpgradeOps
 
 __all__ = ("add_migration_commands", "get_alchemy_group")
 
@@ -157,7 +157,7 @@ def show_database_revision(bind_key: Optional[str], verbose: bool) -> None:  # p
         """Show current database revision."""
         from advanced_alchemy.alembic.commands import AlembicCommands
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Listing current revision[/]", align="left")
         sqlalchemy_config = get_config_by_bind_key(ctx, bind_key)
         alembic_commands = AlembicCommands(sqlalchemy_config=sqlalchemy_config)
@@ -189,7 +189,7 @@ def downgrade_database(  # pyright: ignore[reportUnusedFunction]
 
         from advanced_alchemy.alembic.commands import AlembicCommands
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Starting database downgrade process[/]", align="left")
         input_confirmed = (
             True
@@ -227,7 +227,7 @@ def upgrade_database(  # pyright: ignore[reportUnusedFunction]
 
         from advanced_alchemy.alembic.commands import AlembicCommands
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Starting database upgrade process[/]", align="left")
         input_confirmed = (
             True
@@ -248,7 +248,7 @@ def stamp(bind_key: Optional[str], revision: str) -> None:  # pyright: ignore[re
         """Stamp the revision table with the given revision."""
         from advanced_alchemy.alembic.commands import AlembicCommands
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         sqlalchemy_config = get_config_by_bind_key(ctx, bind_key)
         alembic_commands = AlembicCommands(sqlalchemy_config=sqlalchemy_config)
         alembic_commands.stamp(revision=revision)
@@ -274,7 +274,7 @@ def init_alembic(  # pyright: ignore[reportUnusedFunction]
 
         from advanced_alchemy.alembic.commands import AlembicCommands
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Initializing database migrations.", align="left")
         input_confirmed = (
             True if no_prompt else Confirm.ask("[bold]Are you sure you want initialize migrations for the project?[/]")
@@ -345,7 +345,7 @@ def process_revision_directives(
                 )
                 directives.clear()
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Starting database upgrade process[/]", align="left")
         if message is None:
             message = "autogenerated" if no_prompt else Prompt.ask("Please enter a message describing this revision")
@@ -375,7 +375,7 @@ def drop_all(bind_key: Optional[str], no_prompt: bool) -> None:  # pyright: igno
         from advanced_alchemy.alembic.utils import drop_all
         from advanced_alchemy.base import metadata_registry
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         console.rule("[yellow]Dropping all tables from the database[/]", align="left")
         input_confirmed = no_prompt or Confirm.ask(
             "[bold red]Are you sure you want to drop all tables from the database?"
@@ -418,7 +418,7 @@ def dump_table_data(bind_key: Optional[str], table_names: tuple[str, ...], dump_
         from advanced_alchemy.alembic.utils import dump_tables
         from advanced_alchemy.base import metadata_registry, orm_registry
 
-        ctx = click.get_current_context()
+        ctx = cast("click.Context", click.get_current_context())
         all_tables = "*" in table_names
 
         if all_tables and not Confirm.ask(

advanced_alchemy/extensions/flask/cli.py

@@ -50,7 +50,7 @@ def database_group() -> None:
     This command group provides database management commands like migrations.
     """
 
-    ctx = click.get_current_context()
+    ctx = cast("click.Context", click.get_current_context())
     app = ctx.obj.load_app()
     ctx.obj = {"app": app, "configs": get_database_migration_plugin(app).config}
 

advanced_alchemy/repository/memory/_async.py

@@ -112,7 +112,7 @@ def __init__(
         self.uniquify = bool(uniquify)
 
     def __init_subclass__(cls) -> None:
-        cls.__database_registry__[cls] = cls.__database__  # pyright: ignore[reportGeneralTypeIssues,reportUnknownMemberType]
+        cls.__database_registry__[cls] = cls.__database__  # type: ignore[index]
 
     @staticmethod
     def _get_error_messages(
@@ -131,7 +131,7 @@ def _get_error_messages(
 
     @classmethod
     def __database_add__(cls, identity: Any, data: ModelT) -> ModelT:
-        return cast("ModelT", cls.__database__.add(identity, data))  # pyright: ignore[reportUnnecessaryCast,reportGeneralTypeIssues]
+        return cast("ModelT", cls.__database__.add(identity, data))  # type: ignore[redundant-cast]
 
     @classmethod
     def __database_clear__(cls) -> None:

advanced_alchemy/repository/memory/_sync.py

@@ -113,7 +113,7 @@ def __init__(
         self.uniquify = bool(uniquify)
 
     def __init_subclass__(cls) -> None:
-        cls.__database_registry__[cls] = cls.__database__  # pyright: ignore[reportGeneralTypeIssues,reportUnknownMemberType]
+        cls.__database_registry__[cls] = cls.__database__  # type: ignore[index]
 
     @staticmethod
     def _get_error_messages(
@@ -132,7 +132,7 @@ def _get_error_messages(
 
     @classmethod
     def __database_add__(cls, identity: Any, data: ModelT) -> ModelT:
-        return cast("ModelT", cls.__database__.add(identity, data))  # pyright: ignore[reportUnnecessaryCast,reportGeneralTypeIssues]
+        return cast("ModelT", cls.__database__.add(identity, data))  # type: ignore[redundant-cast]
 
     @classmethod
     def __database_clear__(cls) -> None: