fix: updated_at not being updated (#551)

Corrects a regression where `updated_at` timestamp was no longer updated on model changes

Author: Harshal6927

advanced_alchemy/_listeners.py

@@ -12,6 +12,7 @@
 
 if TYPE_CHECKING:
     from sqlalchemy.orm import Session, UOWTransaction
+    from sqlalchemy.orm.state import InstanceState
 
     from advanced_alchemy.types.file_object import FileObjectSessionTracker, StorageRegistry
 
@@ -452,8 +453,31 @@ def touch_updated_timestamp(session: "Session", *_: Any) -> None:  # pragma: no
     """
     for instance in session.dirty:
         state = inspect(instance)
-        if not state or not hasattr(state.mapper.class_, "updated_at"):
+        if not state or not hasattr(state.mapper.class_, "updated_at") or state.deleted or instance in session.new:
             continue
         updated_at_attr = state.attrs.get("updated_at")
-        if updated_at_attr and not updated_at_attr.history.has_changes():
+        if not updated_at_attr or updated_at_attr.history.added:
+            # Respect explicit user assignments such as manual overrides or import routines
+            continue
+
+        if _has_persistent_column_changes(state, skip_keys={"updated_at"}):
             instance.updated_at = datetime.datetime.now(datetime.timezone.utc)
+
+
+def _has_persistent_column_changes(
+    state: "InstanceState[Any]",
+    *,
+    skip_keys: "Optional[set[str]]" = None,
+) -> bool:
+    """Check if any mapped column (excluding ``skip_keys``) has modifications pending flush."""
+    if skip_keys is None:
+        skip_keys = set()
+
+    mapper = state.mapper
+    for attr in mapper.column_attrs:
+        if attr.key in skip_keys:
+            continue
+        attr_state = state.attrs.get(attr.key)
+        if attr_state is not None and attr_state.history.has_changes():
+            return True
+    return False

advanced_alchemy/repository/_async.py

@@ -1586,12 +1586,17 @@ async def update_many(
             error_messages=error_messages,
             default_messages=self.error_messages,
         )
+        supports_updated_at = hasattr(self.model_type, "updated_at")
         data_to_update: list[dict[str, Any]] = []
         for v in data:
             if isinstance(v, self.model_type) or (hasattr(v, "to_dict") and callable(v.to_dict)):
-                data_to_update.append(v.to_dict())
+                update_payload = v.to_dict()
             else:
-                data_to_update.append(cast("dict[str, Any]", schema_dump(v)))
+                update_payload = cast("dict[str, Any]", schema_dump(v))
+
+            if supports_updated_at and (update_payload.get("updated_at") is None):
+                update_payload["updated_at"] = datetime.datetime.now(datetime.timezone.utc)
+            data_to_update.append(update_payload)
         with wrap_sqlalchemy_exception(
             error_messages=error_messages, dialect_name=self._dialect.name, wrap_exceptions=self.wrap_exceptions
         ):

advanced_alchemy/repository/_sync.py

@@ -1587,12 +1587,17 @@ def update_many(
             error_messages=error_messages,
             default_messages=self.error_messages,
         )
+        supports_updated_at = hasattr(self.model_type, "updated_at")
         data_to_update: list[dict[str, Any]] = []
         for v in data:
             if isinstance(v, self.model_type) or (hasattr(v, "to_dict") and callable(v.to_dict)):
-                data_to_update.append(v.to_dict())
+                update_payload = v.to_dict()
             else:
-                data_to_update.append(cast("dict[str, Any]", schema_dump(v)))
+                update_payload = cast("dict[str, Any]", schema_dump(v))
+
+            if supports_updated_at and (update_payload.get("updated_at") is None):
+                update_payload["updated_at"] = datetime.datetime.now(datetime.timezone.utc)
+            data_to_update.append(update_payload)
         with wrap_sqlalchemy_exception(
             error_messages=error_messages, dialect_name=self._dialect.name, wrap_exceptions=self.wrap_exceptions
         ):

advanced_alchemy/service/_async.py

@@ -474,7 +474,7 @@ def filter_unset(attr: Any, value: Any) -> bool:  # noqa: ARG001
             )
 
         # Fallback for objects with __dict__ (e.g., regular classes)
-        if hasattr(data, "__dict__"):
+        if hasattr(data, "__dict__") and not isinstance(data, self.model_type):
             return model_from_dict(
                 model=self.model_type,
                 **data.__dict__,

advanced_alchemy/service/_sync.py

@@ -473,7 +473,7 @@ def filter_unset(attr: Any, value: Any) -> bool:  # noqa: ARG001
             )
 
         # Fallback for objects with __dict__ (e.g., regular classes)
-        if hasattr(data, "__dict__"):
+        if hasattr(data, "__dict__") and not isinstance(data, self.model_type):
             return model_from_dict(
                 model=self.model_type,
                 **data.__dict__,

docs/usage/modeling.rst

@@ -57,6 +57,7 @@ Additionally, Advanced Alchemy provides mixins to enhance model functionality:
    * - ``AuditColumns``
      - | Automatic created_at/updated_at timestamps
        | Tracks record modifications
+      | ``updated_at`` refreshes during flush when any mapped column value changes, while preserving explicit timestamp overrides
    * - ``BigIntPrimaryKey``
      - | Adds BigInt primary key with sequence
    * - ``IdentityPrimaryKey``

tests/integration/test_repository.py

@@ -1,5 +1,6 @@
 """Integration tests for the SQLAlchemy Repository implementation using session-based fixtures."""
 
+import asyncio
 import datetime
 from collections.abc import Generator
 from typing import TYPE_CHECKING, Any, Literal, Optional, Union
@@ -339,14 +340,43 @@ async def test_repo_update_method(seeded_test_session_async: "tuple[AsyncSession
     # Get first author
     authors = await maybe_async(author_repo.list())
     author = authors[0]
+
     original_name = author.name
+    original_created_at = author.created_at
+    original_updated_at = author.updated_at
 
     # Update the author
     author.name = "Updated Name"
     updated_author = await maybe_async(author_repo.update(author))
 
     assert updated_author.name == "Updated Name"
     assert updated_author.name != original_name
+    assert updated_author.created_at == original_created_at
+    assert updated_author.updated_at > original_updated_at
+
+
+async def test_service_update_with_dict_data_refreshes_timestamp(
+    seeded_test_session_async: "tuple[AsyncSession, dict[str, type]]",
+    frozen_datetime: "Coordinates",
+) -> None:
+    """Service update should refresh audit timestamps when supplied with dict payloads."""
+    session, models = seeded_test_session_async
+    author_service = get_service_from_session((session, models), "author")
+
+    authors = await maybe_async(author_service.list())
+    author = authors[0]
+
+    original_created_at = author.created_at
+    original_updated_at = author.updated_at
+
+    frozen_datetime.shift(datetime.timedelta(seconds=5))
+    update_payload = {"name": "Dict Driven Update"}
+
+    updated_author = await maybe_async(author_service.update(update_payload, item_id=author.id))
+
+    assert updated_author.name == "Dict Driven Update"
+    assert updated_author.created_at == original_created_at
+    assert updated_author.updated_at > original_updated_at
 
 
 async def test_repo_update_many_method_stale_data_fix(
@@ -385,7 +415,7 @@ async def test_repo_update_many_method_stale_data_fix(
         # updated_at should be newer than before
         if updated_author.id == authors[0].id:
             assert updated_author.created_at == original_created_at
-            assert updated_author.updated_at >= original_updated_at
+            assert updated_author.updated_at > original_updated_at
 
 
 async def test_repo_update_many_mixed_types(seeded_test_session_async: "tuple[AsyncSession, dict[str, type]]") -> None:
@@ -498,11 +528,18 @@ async def test_service_update_method(seeded_test_session_async: "tuple[AsyncSess
     author = authors[0]
     author_id = author.id
 
+    original_name = author.name
+    original_created_at = author.created_at
+    original_updated_at = author.updated_at
+
     # Update via service - correct parameter order is (data, item_id)
-    update_data = {"name": "Service Updated Name"}
-    updated_author = await maybe_async(author_service.update(update_data, item_id=author_id))
+    author.name = "Service Updated Name"
+    updated_author = await maybe_async(author_service.update(author, item_id=author_id))
 
     assert updated_author.name == "Service Updated Name"
+    assert updated_author.name != original_name
+    assert updated_author.created_at == original_created_at
+    assert updated_author.updated_at > original_updated_at
 
 
 async def test_service_delete_method(seeded_test_session_async: "tuple[AsyncSession, dict[str, type]]") -> None:
@@ -679,6 +716,10 @@ async def test_service_update_many_schema_types_github_535(
 
     original_dob1 = author1.dob
     original_dob2 = author2.dob
+    original_created_at1 = author1.created_at
+    original_created_at2 = author2.created_at
+    original_updated_at1 = author1.updated_at
+    original_updated_at2 = author2.updated_at
 
     # Get ID type from model for dynamic schema creation
     # For Pydantic compatibility, we need to map database-specific types to Python types
@@ -707,6 +748,9 @@ class AuthorUpdateMsgspecSchema(msgspec.Struct):  # type: ignore[name-defined,mi
         AuthorUpdateMsgspecSchema(id=author2.id, name="Updated Author Two"),  # msgspec with UNSET dob
     ]
 
+    # Sleep to ensure timestamp difference for databases with lower precision
+    await asyncio.sleep(1.1)
+
     # Update via service - should only update names, leave dobs unchanged
     updated_authors = await maybe_async(author_service.update_many(update_data))
 
@@ -720,9 +764,13 @@ class AuthorUpdateMsgspecSchema(msgspec.Struct):  # type: ignore[name-defined,mi
     # Verify: names were updated, but dobs remain unchanged
     assert updated_author1.name == "Updated Author One"
     assert updated_author1.dob == original_dob1  # Should be unchanged
+    assert updated_author1.created_at == original_created_at1
+    assert updated_author1.updated_at > original_updated_at1
 
     assert updated_author2.name == "Updated Author Two"
     assert updated_author2.dob == original_dob2  # Should be unchanged
+    assert updated_author2.created_at == original_created_at2
+    assert updated_author2.updated_at > original_updated_at2
 
 
 async def test_repo_update_many_non_returning_backend_refresh(