Fix dual adjoint BC setter#1612
Open
ebchin wants to merge 5 commits into
Open
Conversation
ebchin
commented
Jun 2, 2026
ebchin
commented
Member
- Improves parsing of dual adjoint BC field names (first tries to match in derived class, then calls base class version)
- Makes the "contact_force" dual adjoint BC work correctly (so you can calculate sensitivities w.r.t. all of the contact forces)
tupek2
reviewed
Jun 8, 2026
| /// @overload | ||
| const FiniteElementState& dualAdjoint(const std::string& dual_name) const override | ||
| { | ||
| if (isAggregateContactForceName(dual_name)) { |
Collaborator
There was a problem hiding this comment.
I would vote for us not supporting aggregated contact interaction forces at all. it makes no sense to me personally as an output in the first place and LiDO users can just compute it themselves by summing contact interactions if they ever come up with some justification. I think it adds too much unneeded complications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.