Test that toll-free bridged CFArray's are still bounds-checked

Author: madsmtm

Cargo.lock

@@ -28,6 +28,7 @@ block2 = { workspace = true, features = ["std"] }
 objc2 = { workspace = true, features = ["std", "relax-void-encoding"] }
 objc2-foundation = { workspace = true, features = [
     "std",
+    "objc2-core-foundation",
     "NSArray",
     "NSAttributedString",
     "NSDecimalNumber",
@@ -48,6 +49,12 @@ objc2-foundation = { workspace = true, features = [
     "NSThread",
     "NSValue",
 ] }
+objc2-core-foundation = { workspace = true, features = [
+    "std",
+    "objc2",
+    "CFArray",
+    "CFNumber",
+] }
 rustc-demangle = "0.1.26"
 # Unbreak CI until this gets a new release:
 # https://github.com/mcountryman/simd-adler32/pull/37

crates/tests/Cargo.toml

@@ -5,10 +5,11 @@
 #![cfg(target_vendor = "apple")]
 #![cfg(feature = "exception")] // For `should_panic` to work
 
-use core::{panic::AssertUnwindSafe, ptr::NonNull};
+use core::panic::AssertUnwindSafe;
 use std::string::ToString;
 
 use objc2::AnyThread;
+use objc2_core_foundation::{CFArray, CFNumber};
 use objc2_foundation::{
     NSArray, NSAttributedString, NSDictionary, NSException, NSIndexSet, NSMethodSignature,
     NSMutableArray, NSNotFound, NSObject, NSOrderedSet, NSPointerArray, NSRange, NSString,
@@ -63,6 +64,24 @@ fn array() {
     });
 }
 
+#[test]
+// FIXME: Encoding checks shouldn't be this strict.
+#[cfg_attr(
+    debug_assertions,
+    ignore = "type encoding is apparently... ^{__CFNumber=}"
+)]
+fn cf_array_toll_free_bridged() {
+    let arr = CFArray::from_retained_objects(&[CFNumber::new_i32(42), CFNumber::new_f32(64.0)]);
+    let arr: &NSArray<CFNumber> = arr.as_ref();
+
+    let _ = arr.objectAtIndex(0);
+    let _ = arr.objectAtIndex(1);
+
+    assert_throws("index 100 beyond bounds [0 .. 1]", || {
+        arr.objectAtIndex(100)
+    });
+}
+
 #[test]
 fn attributed_string() {
     let arr = unsafe {
@@ -90,7 +109,7 @@ fn index_set() {
 #[test]
 fn method_signature() {
     let sig = c"c@:@";
-    let sig = unsafe { NSMethodSignature::signatureWithObjCTypes(sig) }.unwrap();
+    let sig = NSMethodSignature::signatureWithObjCTypes(sig).unwrap();
     assert_throws("index (100) out of bounds [0, 2]", || {
         sig.getArgumentTypeAtIndex(100)
     });