Skip to content

Counter's PT boost and gain ability must use layer's timestamps like other effects? #15696

Description

@JayDi85

from #15695

No real bugs exists, for info only

xmage uses global ApplyStatusEffect to apply:

  • PT boost from counters;
  • gain ability from counters like manace counter;

It's called directly in each game cycle on related layers:

  • Layer.AbilityAddingRemovingEffects_6
  • Layer.PTChangingEffects_7

But there are potential problem with effects dependencies and timestamps -- all other effects apply by layers and timestamps thanks to paper rules and getLayeredEffects, but not ApplyStatusEffect

As example: if some potential counter's AbilityAddingRemovingEffects_6 effect lookup for some gained ability (e.g. depends on it) then it will be buggy cause it applies first all the time instead effect's timestamp and dependency.

Image

One of the possible solution (if such bugs really exists): inject per permanent ApplyStatusEffect in getLayeredEffects.

P.S. related issue with "layers 7c and 7d have been merged": #11692

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactoringDevelopers topics about code and programming

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions