Skip to content

Commit 647fc06

Browse files
authored
Update maintainers file (#471)
* update maintainers file * try bumping flang * do not set env var FC * remove unused windows.yaml file * cleaned up docs
1 parent cc8b880 commit 647fc06

5 files changed

Lines changed: 5 additions & 51 deletions

File tree

.github/CODEOWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
* @mdolab/pyoptsparse_maintainers
2+
* @ewu63
3+
* @marcomangano

.github/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ dependencies:
99
- pip
1010
- setuptools
1111
- build
12-
- flang 5*
12+
- flang>=18
1313
- libpgmath
1414
# runtime
1515
- packaging

.github/windows.yaml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.github/workflows/windows-build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ jobs:
3636
:: debug - list environment vars
3737
set
3838
39-
:: set fortran compiler, flang 5 activation doesn't seem to do it
40-
set FC=flang.exe
41-
4239
python -m build -n -x .
4340
4441
pip install --no-deps --no-index --find-links dist pyoptsparse

doc/install.rst

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Installation Instructions
55

66
Conda
77
-----
8-
Conda packages are available on ``conda-forge`` and can be installed via
8+
Conda packages are available on conda-forge and can be installed via
99

1010
.. prompt:: bash
1111

@@ -165,7 +165,7 @@ This has the advantage that ``conda`` can be used to install all the necessary d
165165
Considering how finicky Windows can be with ABI compatibility among various compilers, this is the recommended approach.
166166
The guide will work on any platform, however.
167167

168-
The only build requirement for the build is a working ``conda`` installation as all compilers and dependencies are pulled from the ``conda-forge`` repos, with the exception of a Windows build, which requires Visual Studio 2017 C++ Build Tools.
168+
The only build requirement for the build is a working ``conda`` installation as all compilers and dependencies are pulled from conda-forge.
169169

170170
First, we need to create the ``conda`` environment.
171171
An ``environment.yml`` file is provided in the ``pyoptsparse`` repo:
@@ -204,11 +204,6 @@ Finally, build the wheel and install it using pip:
204204

205205
.. code-tab:: powershell Windows
206206

207-
# set specific compiler flags
208-
set CC=cl
209-
set FC=flang
210-
set CC_LD=link
211-
212207
# build wheel
213208
python -m build -n -x .
214209

0 commit comments

Comments
 (0)