refactor(platform): abstract process management for Unix and Windows environments

Author: GenerQAQ

src/client/acontext-cli/cmd/create_test.go

@@ -90,4 +90,3 @@ func TestValidateProjectName(t *testing.T) {
 		})
 	}
 }
-

src/client/acontext-cli/cmd/server.go

@@ -7,7 +7,6 @@ import (
 	"os/exec"
 	"os/signal"
 	"path/filepath"
-	"runtime"
 	"strings"
 	"sync"
 	"syscall"
@@ -17,6 +16,7 @@ import (
 	"github.com/charmbracelet/lipgloss"
 	"github.com/memodb-io/Acontext/acontext-cli/internal/docker"
 	"github.com/memodb-io/Acontext/acontext-cli/internal/pkgmgr"
+	"github.com/memodb-io/Acontext/acontext-cli/internal/platform"
 	"github.com/memodb-io/Acontext/acontext-cli/internal/sandbox"
 	"github.com/spf13/cobra"
 )
@@ -516,9 +516,7 @@ func runServerUp(cmd *cobra.Command, args []string) error {
 		mu.Lock()
 		sandboxCmd = exec.Command(parts[0], parts[1:]...)
 		sandboxCmd.Dir = projectDir
-		if runtime.GOOS != "windows" {
-			sandboxCmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
-		}
+		platform.SetProcessGroup(sandboxCmd)
 		mu.Unlock()
 
 		sandboxStdout, err := sandboxCmd.StdoutPipe()
@@ -689,25 +687,12 @@ func runServerUp(cmd *cobra.Command, args []string) error {
 func cleanup(cwd string, mu *sync.Mutex, sandboxCmd, dockerLogsCmd *exec.Cmd, dockerComposeFile string) {
 	mu.Lock()
 	if sandboxCmd != nil && sandboxCmd.Process != nil {
-		if runtime.GOOS != "windows" {
-			pgid, err := syscall.Getpgid(sandboxCmd.Process.Pid)
-			if err == nil {
-				if err := syscall.Kill(-pgid, syscall.SIGTERM); err != nil {
-					fmt.Printf("⚠️  Warning: failed to send SIGTERM to process group: %v\n", err)
-				}
-				time.Sleep(500 * time.Millisecond)
-				if err := syscall.Kill(-pgid, syscall.SIGKILL); err != nil {
-					fmt.Printf("⚠️  Warning: failed to send SIGKILL to process group: %v\n", err)
-				}
-			} else {
-				if err := sandboxCmd.Process.Kill(); err != nil {
-					fmt.Printf("⚠️  Warning: failed to kill sandbox process: %v\n", err)
-				}
-			}
-		} else {
-			if err := sandboxCmd.Process.Kill(); err != nil {
-				fmt.Printf("⚠️  Warning: failed to kill sandbox process: %v\n", err)
-			}
+		if err := platform.KillProcessGroup(sandboxCmd); err != nil {
+			fmt.Printf("⚠️  Warning: failed to send SIGTERM to process group: %v\n", err)
+		}
+		time.Sleep(500 * time.Millisecond)
+		if err := platform.KillProcessGroupForce(sandboxCmd); err != nil {
+			fmt.Printf("⚠️  Warning: failed to send SIGKILL to process group: %v\n", err)
 		}
 		if err := sandboxCmd.Wait(); err != nil {
 			fmt.Printf("⚠️  Warning: sandbox process wait error: %v\n", err)

src/client/acontext-cli/internal/docker/checker.go

@@ -29,4 +29,3 @@ func CheckDockerInstalled() error {
 
 	return nil
 }
-

src/client/acontext-cli/internal/docker/env_test.go

@@ -28,7 +28,7 @@ func TestGenerateEnvFile(t *testing.T) {
 		},
 	}
 
-		for _, tt := range tests {
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			// Create directory if needed
 			dir := filepath.Dir(tt.filePath)
@@ -44,7 +44,7 @@ func TestGenerateEnvFile(t *testing.T) {
 				},
 				RootAPIBearerToken: "test-root-token",
 			}
-			
+
 			err = GenerateEnvFile(tt.filePath, envConfig)
 			if tt.wantErr {
 				assert.Error(t, err)
@@ -95,4 +95,3 @@ func TestGenerateEnvFile(t *testing.T) {
 		})
 	}
 }
-

src/client/acontext-cli/internal/git/init.go

@@ -107,4 +107,3 @@ temp/
 
 	return os.WriteFile(gitignorePath, []byte(content), 0644)
 }
-

src/client/acontext-cli/internal/git/init_test.go

@@ -11,19 +11,19 @@ import (
 
 func TestEnsureGitignore(t *testing.T) {
 	tests := []struct {
-		name      string
+		name       string
 		fileExists bool
-		wantErr   bool
+		wantErr    bool
 	}{
 		{
-			name:      "create new gitignore",
+			name:       "create new gitignore",
 			fileExists: false,
-			wantErr:   false,
+			wantErr:    false,
 		},
 		{
-			name:      "skip if gitignore exists",
+			name:       "skip if gitignore exists",
 			fileExists: true,
-			wantErr:   false,
+			wantErr:    false,
 		},
 	}
 
@@ -62,4 +62,3 @@ func TestEnsureGitignore(t *testing.T) {
 		})
 	}
 }
-

src/client/acontext-cli/internal/platform/unix.go

@@ -0,0 +1,45 @@
+//go:build !windows
+// +build !windows
+
+package platform
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+// SetProcessGroup sets the process group for Unix systems
+func SetProcessGroup(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}
+
+// KillProcessGroup kills a process group on Unix systems
+func KillProcessGroup(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+	pgid, err := syscall.Getpgid(cmd.Process.Pid)
+	if err != nil {
+		// If we can't get the process group, just kill the process
+		return cmd.Process.Kill()
+	}
+	// Send SIGTERM to the process group
+	if err := syscall.Kill(-pgid, syscall.SIGTERM); err != nil {
+		return err
+	}
+	return nil
+}
+
+// KillProcessGroupForce forcefully kills a process group on Unix systems
+func KillProcessGroupForce(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+	pgid, err := syscall.Getpgid(cmd.Process.Pid)
+	if err != nil {
+		// If we can't get the process group, just kill the process
+		return cmd.Process.Kill()
+	}
+	// Send SIGKILL to the process group
+	return syscall.Kill(-pgid, syscall.SIGKILL)
+}

src/client/acontext-cli/internal/platform/windows.go

@@ -0,0 +1,27 @@
+//go:build windows
+// +build windows
+
+package platform
+
+import "os/exec"
+
+// SetProcessGroup is a no-op on Windows
+func SetProcessGroup(cmd *exec.Cmd) {
+	// Windows doesn't support process groups in the same way
+}
+
+// KillProcessGroup kills a process on Windows (no process groups)
+func KillProcessGroup(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+	return cmd.Process.Kill()
+}
+
+// KillProcessGroupForce forcefully kills a process on Windows (no process groups)
+func KillProcessGroupForce(cmd *exec.Cmd) error {
+	if cmd == nil || cmd.Process == nil {
+		return nil
+	}
+	return cmd.Process.Kill()
+}