feat(core): clean task agent prompt

Author: gusye1234

src/server/core/acontext_core/llm/agent/task.py

@@ -44,7 +44,10 @@ def pack_previous_messages_section(
             LOG.warning(f"Unknown task id: {ti}")
             task_descs.append("(no task linked)")
     return "\n---\n".join(
-        [f"{td}\n{m.to_string()}" for td, m in zip(task_descs, messages)]
+        [
+            f"{td}\n{m.to_string(truncate_chars=200)}"
+            for td, m in zip(task_descs, messages)
+        ]
     )
 
 
@@ -76,7 +79,7 @@ async def task_agent_curd(
     session_id: asUUID,
     previous_messages: List[MessageBlob],
     messages: List[MessageBlob],
-    max_iterations=1,  # task curd agent only receive one turn of actions
+    max_iterations=3,  # task curd agent only receive one turn of actions
 ) -> Result[None]:
     async with DB_CLIENT.get_session_context() as db_session:
         r = await TD.fetch_current_tasks(db_session, session_id)

src/server/core/acontext_core/llm/complete/openai_sdk.py

@@ -62,11 +62,6 @@ async def openai_complete(
     )
 
     # Only support tool calls
-    # _fc = (
-    #     response.choices[0].message.function_call.model_dump()
-    #     if response.choices[0].message.function_call
-    #     else None
-    # )
     _tu = (
         [
             convert_openai_tool_to_llm_tool(tool)
@@ -75,8 +70,6 @@ async def openai_complete(
         if response.choices[0].message.tool_calls
         else None
     )
-    # if not _tu and _fc:
-    #     _tu = [_fc]
 
     llm_response = LLMResponse(
         role=response.choices[0].message.role,

src/server/core/acontext_core/llm/prompt/task.py

@@ -11,47 +11,45 @@ def system_prompt(cls) -> str:
         return f"""You are a Task Management Agent that analyzes user/agent conversations to manage task statuses.
 
 ## Core Responsibilities
-1. **New Task Detection**: Identify new tasks, goals, or objectives requiring tracking
-2. **Task Assignment**: Match messages to existing tasks based on context and content  
-3. **Status Management**: Update task statuses based on progress and completion signals
+1. **Task Tracking**: Collect planned tasks/steps from converations.
+2. **Message Matching**: Match messages to existing tasks based on context and content  
+3. **Status Updating**: Update task statuses based on progress and completion signals
 
 ## Task System
 **Structure**: 
 - Tasks have description, status, and sequential order (`task_order=1, 2, ...`) within sessions. 
 - Messages link to tasks via their IDs.
 
 **Statuses**: 
-- `pending`: Created but not started (default)
-- `running`: Currently being processed
-- `success`: Completed successfully  
-- `failed`: Encountered errors or abandoned
+- `pending`
+- `running`
+- `success`
+- `failed`
 
-## Analysis Guidelines
-### Planning Detection
+## Planning Detection
 - Planning messages often consist of user and agent discussions, clarify what's tasks to do at next.
 - Append those messages to planning section.
 
-### Task Creation/Modifcation
-- Collect planned tasks from converations.
-- Tasks are often confirmed by the agent's response to user's requirements.
-- Only collect tasks stated by agents/users, don't invent them
-- Readout the existing tasks, make sure you will locate the correct existing task when user/agent talks about them.
+## Task Creation/Modifcation
+- Tasks are often confirmed by the agent's response to user's requirements, don't invent them.
+- keep task granularity align with the steps in planning: 
+    1. Do not create just one large and comprehensive task, nor only the first task in the plan.
+    2. Try use the top-level tasks in the planning(often 3~10 tasks), don't create excessive subtasks.
+- Make sure you will locate the correct existing task and modify then when necessary.
 - Ensure the new tasks are MECE(mutually exclusive, collectively exhaustive) to existing tasks.
-- No matter the task is actionable/executable or not, you job is to honestly record every possible new tasks.
+- No matter the task is executing or not, you job is to collect ALL POSSIBLE tasks mentioned in the planning.
 - When user asked for tasks modification and agent confirmed, you need to think:
-    a. user/agent is inside/referring an existing task
-    b. user/agent is creating a new task that don't have any similar existing task.
-    If (a), modify the existing task' description using `update_task` tool.
-    If (b), create a new task following the New Task Creation guidelines.
-    Understand the Current Tasks, and if not necessary, don't create a similar task, try to locate the existing task and modify it.
+    a. user/agent is inside/referring an existing task. If so, modify the existing task' description using `update_task` tool.
+    b. user/agent is creating a new task that don't have any similar existing task. If so, create a new task following the New Task Creation guidelines.
+    If not necessary, don't create a similar task, try to modify the existing task.
 
-### Append Messages to Task
+## Append Messages to Task
 - Match agent responses/actions to existing task descriptions and contexts
 - No need to link every message, just those messages that are contributed to the process of certain tasks.
 - Make sure the messages are contributed to the process of the task, not just doing random linking.
 - Update task statuses or descriptions when confident about relationships 
 
-### Update Task Status 
+## Update Task Status 
 - `running`: When task work begins or is actively discussed
 - `success`: When completion is confirmed or deliverables provided
 - `failed`: When explicit errors occur or tasks are abandoned
@@ -60,31 +58,28 @@ def system_prompt(cls) -> str:
 
 ## Input Format
 - Input will be markdown-formatted text, with the following sections:
-  - `## Current Tasks`: existing tasks, their orders, descriptions, and statuses
-  - `## Previous Messages`: the history messages of user/agent, help you understand the full context. [no message id]
+  - `## Current Existing Tasks`: existing tasks, their orders, descriptions, and statuses
+  - `## Previous Messages`: the history messages of user/agent, help you understand the full context. [no message id, maybe truncated]
   - `## Current Message with IDs`: the current messages that you need to analyze [with message ids]
 - Message with ID format: <message id=N> ... </message>, inside the tag is the message content, the id field indicates the message id.
 
-## Report your thinking before calling tools
+## Report your Thinking
 Use extremely brief wordings to report:
-- Any new user requirement or planning ? For each task, is it a task modification or creation situation?
-- How existing tasks are related to current conversation? Do the existing tasks need to be updated?
-- Messages are contributed to which task?
-- Do New/Existing tasks' status need to be updated?
-- Briefly describe your actions.
-- Conform your will call every necessary tools in one response.
-
-## Action Guidelines
-- Be precise, context-aware, and conservative. 
-- Focus on meaningful task management that organizes conversation objectives effectively. 
-- Use parallel tool calls, and make sure you call the tools in the correct order.
+1. Any new user requirement or planning? What are the tasks/steps?
+2. For each task, is it a task modification or creation situation?
+3. How existing tasks are related to current conversation? Do the existing tasks need to be updated?
+4. Messages are contributed to which task?
+5. Do New/Existing tasks' status need to be updated?
+6. Describe your actions.
+7. Confirm your will call every necessary tools in this response.
+8. Confirm your will call `finish` tool once every tools are called
 """
 
     @classmethod
     def pack_task_input(
         cls, previous_messages: str, current_message_with_ids: str, current_tasks: str
     ) -> str:
-        return f"""## Current Tasks:
+        return f"""## Current Existing Tasks:
 {current_tasks}
 
 ## Previous Messages:
@@ -108,12 +103,12 @@ def tool_schema(cls) -> list[ToolSchema]:
             "append_messages_to_planning_section"
         ].schema
         append_messages_to_task_tool = TASK_TOOLS["append_messages_to_task"].schema
-        # finish_tool = TASK_TOOLS["finish"].schema
+        finish_tool = TASK_TOOLS["finish"].schema
 
         return [
             insert_task_tool,
             update_task_tool,
             append_messages_to_planning_tool,
             append_messages_to_task_tool,
-            # finish_tool,
+            finish_tool,
         ]

src/server/core/acontext_core/schema/session/message.py

@@ -17,11 +17,13 @@ def pack_part_line(role: str, part: Part) -> str:
     role = REPLACE_NAME.get(role, role)
     if part.type not in STRING_TYPES:
         return f"<{role}> [{part.type} file: {part.filename}]"
-    if part.type == "text":
+    elif part.type == "text":
         return f"<{role}> {part.text}"
-    if part.type == "tool-call":
+    elif part.type == "tool-call":
         tool_call_meta = ToolCallMeta(**part.meta)
         return f"<{role}> USE TOOL {tool_call_meta.tool_name}, WITH PARAMS {tool_call_meta.arguments}"
+    else:
+        raise TypeError(f"Unknown message part type: {part.type}")
 
 
 class MessageBlob(BaseModel):
@@ -30,6 +32,9 @@ class MessageBlob(BaseModel):
     parts: List[Part]
     task_id: Optional[asUUID] = None
 
-    def to_string(self) -> str:
-        lines = [pack_part_line(self.role, p) for p in self.parts]
-        return "\n".join(lines)
+    def to_string(self, truncate_chars: int = None, **kwargs) -> str:
+        lines = [pack_part_line(self.role, p, **kwargs) for p in self.parts]
+        r = "\n".join(lines)
+        if truncate_chars is None or len(r) < truncate_chars:
+            return r
+        return r[:truncate_chars] + "[...truncated]"