♻️ skip userDataDir when no custom settings, keep workspace trust disabled

Author: mickaelalvs

README.md

@@ -46,7 +46,7 @@ addons:
 <Editor session="demo" />
 ```
 
-That's it. When you navigate to the slide, a VS Code instance starts automatically and loads inside the slide. Each session starts with workspace trust disabled and git repository detection turned off so no setup popups.
+That's it. When you navigate to the slide, a VS Code instance starts automatically and loads inside the slide. The IDE can use your local VS Code configuration for user settings.
 
 ## 📂 Open a specific workspace
 

plugin/sessionManager.ts

@@ -17,7 +17,7 @@ type SessionEntry = {
   close: () => Promise<void>
   port: number
   url: string
-  userDataDir: string
+  userDataDir?: string
 }
 
 type SendEvent = (session: string, url: string, state: 'running' | 'error', error?: string) => void
@@ -55,26 +55,29 @@ export class SessionManager {
       const absoluteFolder = defaultFolder ? resolve(root, defaultFolder) : root
       const resolvedFolder = existsSync(absoluteFolder) ? absoluteFolder : root
 
-      const settings: Record<string, unknown> = {
-        'git.openRepositoryInParentFolders': 'never',
-        'security.workspace.trust.enabled': false,
-      }
+      const settings: Record<string, unknown> = {}
       if (colorScheme) settings['workbench.colorTheme'] = COLOR_THEMES[colorScheme]
       if (fontSize) settings['editor.fontSize'] = fontSize
       if (hideMinimap) settings['editor.minimap.enabled'] = false
       if (hideActivityBar) settings['workbench.activityBar.location'] = 'hidden'
       if (hideStatusBar) settings['workbench.statusBar.visible'] = false
 
-      const userDataDir = mkdtempSync(join(tmpdir(), 'livecode-'))
-      mkdirSync(join(userDataDir, 'User'), { recursive: true })
-      writeFileSync(join(userDataDir, 'User', 'settings.json'), JSON.stringify(settings))
+      let userDataDir: string | undefined
+      if (Object.keys(settings).length > 0) {
+        userDataDir = mkdtempSync(join(tmpdir(), 'livecode-'))
+        mkdirSync(join(userDataDir, 'User'), { recursive: true })
+        writeFileSync(join(userDataDir, 'User', 'settings.json'), JSON.stringify(settings))
+      }
 
       const handle = await Promise.race([
         startCodeServer({
           defaultFolder: resolvedFolder,
           host: '127.0.0.1',
           port,
-          ...(userDataDir ? { vscode: { 'user-data-dir': userDataDir } } : {}),
+          vscode: {
+            'disable-workspace-trust': true,
+            ...(userDataDir ? { 'user-data-dir': userDataDir } : {}),
+          },
         }),
         new Promise<never>((_, reject) =>
           setTimeout(() => reject(new Error(`timeout after ${startTimeout}ms`)), startTimeout),
@@ -101,7 +104,7 @@ export class SessionManager {
     const entry = this.sessions.get(session)
     if (!entry) return
     entry.close().catch(() => {})
-    rmSync(entry.userDataDir, { recursive: true, force: true })
+    if (entry.userDataDir) rmSync(entry.userDataDir, { recursive: true, force: true })
     this.sessions.delete(session)
     this.usedPorts.delete(entry.port)
     console.log(`[livecode] Session "${session}" stopped`)
@@ -110,7 +113,7 @@ export class SessionManager {
   cleanup(): void {
     for (const [, entry] of this.sessions) {
       entry.close().catch(() => {})
-      rmSync(entry.userDataDir, { recursive: true, force: true })
+      if (entry.userDataDir) rmSync(entry.userDataDir, { recursive: true, force: true })
     }
     this.sessions.clear()
     this.usedPorts.clear()