Fix tests for updated HTTP error handling

Update test mocks to include required Response properties (status, url,
clone, text) that createHttpResponseError needs. Also update test
assertions to expect sendAPIFailureTelemetry instead of sendErrorTelemetry
for HTTP errors, matching the new error handling flow.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: Amit Joshi

src/web/client/test/integration/remoteFetchProvider.test.ts

@@ -550,9 +550,18 @@ describe("remoteFetchProvider", () => {
         const portalFs = new PortalsFS();
         await WebExtensionContext.authenticateAndUpdateDataverseProperties();
 
+        const mockResponseBody = JSON.stringify({
+            "@odata.count": 0,
+            "@Microsoft.Dynamics.CRM.totalrecordcount": 0,
+            "value": [],
+        });
         const _mockFetch = stub(fetch, "default").resolves({
             ok: false,
-            statusText: "statusText",
+            status: 500,
+            statusText: "Internal Server Error",
+            url: "https://test.crm.dynamics.com/api/data/v9.2/webpages",
+            clone: function() { return this; },
+            text: () => Promise.resolve(mockResponseBody),
             json: () => {
                 return new Promise((resolve) => {
                     return resolve({
@@ -565,13 +574,18 @@ describe("remoteFetchProvider", () => {
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
         } as any);
 
+        const sendAPIFailureTelemetry = stub(
+            WebExtensionContext.telemetry,
+            "sendAPIFailureTelemetry"
+        );
+
         //Action
         await fetchDataFromDataverseAndUpdateVFS(portalFs);
 
         //Assert
         const sendErrorTelemetryCalls = sendErrorTelemetry.getCalls();
 
-        assert.callCount(sendErrorTelemetry, 5);
+        assert.callCount(sendErrorTelemetry, 4);
         assert.calledWithMatch(sendErrorTelemetryCalls[0], webExtensionTelemetryEventNames.WEB_EXTENSION_POPULATE_WEBSITE_ID_TO_LANGUAGE_SYSTEM_ERROR,
             "populateWebsiteIdToLanguageMap",
             "Only absolute URLs are supported");
@@ -584,10 +598,8 @@ describe("remoteFetchProvider", () => {
         assert.calledWithMatch(sendErrorTelemetryCalls[3], webExtensionTelemetryEventNames.WEB_EXTENSION_POPULATE_SHARED_WORKSPACE_SYSTEM_ERROR,
             "populateSharedWorkspace",
             "Web extension populate shared workspace system error");
-        assert.calledWithMatch(sendErrorTelemetryCalls[4],
-            webExtensionTelemetryEventNames.WEB_EXTENSION_FETCH_DATAVERSE_AND_CREATE_FILES_SYSTEM_ERROR,
-            "fetchFromDataverseAndCreateFiles",
-            `{"ok":false,"statusText":"statusText"}`);
+        // HTTP errors now go through sendAPIFailureTelemetry with status code
+        assert.calledOnce(sendAPIFailureTelemetry);
         assert.calledOnce(_mockFetch);
     });
 

src/web/client/test/integration/remoteSaveProvider.test.ts

@@ -227,10 +227,14 @@ describe("remoteSaveProvider", () => {
     it("saveData_shouldErrorOnDataverseSaveCall_whenFetchReturnsNotOKAndStatusCodeIs304AndIsWebFileV2IsFalse", async () => {
         //Act
         const fileUri: vscode.Uri = { fsPath: "testuri" } as vscode.Uri;
+        const mockResponseBody = JSON.stringify({ error: "Unauthorized" });
         const _mockFetch = stub(fetch, "default").resolves({
             ok: false,
             statusText: "Unauthorized",
             status: 403,
+            url: "https://orgedfe4d6c.crm10.dynamics.com",
+            clone: function() { return this; },
+            text: () => Promise.resolve(mockResponseBody),
             json: () => {
                 return new Promise((resolve) => {
                     return resolve({ value: "value" });
@@ -264,9 +268,9 @@ describe("remoteSaveProvider", () => {
             "pdf"
         );
 
-        const sendErrorTelemetry = stub(
+        const sendAPIFailureTelemetry = stub(
             WebExtensionContext.telemetry,
-            "sendErrorTelemetry"
+            "sendAPIFailureTelemetry"
         );
 
         const showErrorDialog = stub(errorHandler, "showErrorDialog");
@@ -297,12 +301,13 @@ describe("remoteSaveProvider", () => {
             assert.calledOnce(getColumnContent);
             assert.calledOnce(isWebFileV2);
             assert.calledOnce(vscodeParse);
-            assert.calledOnce(sendErrorTelemetry);
+            // HTTP errors now go through sendAPIFailureTelemetry with status code
+            assert.calledOnce(sendAPIFailureTelemetry);
             assert.calledOnce(showErrorDialog);
             const showErrorDialogCalls = showErrorDialog.getCalls()[0];
             expect(
                 showErrorDialogCalls.args[0],
-                "There’s a problem on the back end"
+                "There's a problem on the back end"
             );
             expect(showErrorDialogCalls.args[1], "Try again");
         }