refactor: delete fanout mode, rename values-pipeline -> appset-params-template, validate path/keys, refactor params

Author: mitmx

.gitignore

@@ -11,6 +11,7 @@
 *.dll
 *.so
 *.dylib
+./server
 
 # Test binary, built with `go test -c`
 *.test

Dockerfile

@@ -1,12 +1,13 @@
-FROM golang:1.24 AS build
+FROM golang:1.22-alpine AS build
 WORKDIR /src
-
-COPY go.mod go.sum ./
+COPY go.mod ./
 RUN go mod download
-
 COPY . .
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o /out/server ./cmd/server
+ARG TARGETOS=linux
+ARG TARGETARCH=amd64
+RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -trimpath -ldflags="-s -w" -o /out/argocd-appset-params-template-plugin ./cmd/server
 
 FROM gcr.io/distroless/static-debian12:nonroot
-COPY --from=build /out/server /server
-ENTRYPOINT ["/server"]
+COPY --from=build /out/argocd-appset-params-template-plugin /argocd-appset-params-template-plugin
+EXPOSE 4355
+ENTRYPOINT ["/argocd-appset-params-template-plugin"]

LICENSE

@@ -1,10 +1,28 @@
-.PHONY: test build run
+BINARY := bin/argocd-appset-params-template-plugin
+
+.PHONY: fmt check-fmt vet test build run clean image
+
+fmt:
+	gofmt -w ./cmd ./internal
+
+check-fmt:
+	@test -z "$$(gofmt -l ./cmd ./internal)" || (gofmt -l ./cmd ./internal && exit 1)
+
+vet:
+	go vet ./...
 
 test:
 	go test ./...
 
 build:
-	go build ./cmd/server
+	mkdir -p bin
+	go build -o $(BINARY) ./cmd/server
 
 run:
 	PLUGIN_TOKEN=dev-token go run ./cmd/server
+
+image:
+	docker build -t argocd-appset-params-template-plugin:dev .
+
+clean:
+	rm -rf bin dist coverage.out *.coverprofile

Makefile

@@ -1,12 +1,16 @@
 package main
 
 import (
+	"context"
 	"log"
 	"net/http"
+	"os/signal"
+	"syscall"
+	"time"
 
-	"github.com/mitmx/argocd-values-pipeline-plugin/internal/config"
-	"github.com/mitmx/argocd-values-pipeline-plugin/internal/engine"
-	"github.com/mitmx/argocd-values-pipeline-plugin/internal/server"
+	"github.com/mitmx/argocd-appset-params-template-plugin/internal/config"
+	"github.com/mitmx/argocd-appset-params-template-plugin/internal/engine"
+	"github.com/mitmx/argocd-appset-params-template-plugin/internal/server"
 )
 
 func main() {
@@ -27,7 +31,19 @@ func main() {
 		IdleTimeout:       cfg.IdleTimeout,
 	}
 
-	log.Printf("values-pipeline-plugin listening on %s", cfg.Addr)
+	ctx, stop := signal.NotifyContext(context.Background(), syscall.SIGINT, syscall.SIGTERM)
+	defer stop()
+
+	go func() {
+		<-ctx.Done()
+		shutdownCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
+		defer cancel()
+		if err := httpServer.Shutdown(shutdownCtx); err != nil {
+			log.Printf("shutdown: %v", err)
+		}
+	}()
+
+	log.Printf("argocd-appset-params-template-plugin listening on %s", cfg.Addr)
 	if err := httpServer.ListenAndServe(); err != nil && err != http.ErrServerClosed {
 		log.Fatalf("listen: %v", err)
 	}

cmd/server/main.go

@@ -0,0 +1,76 @@
+apiVersion: argoproj.io/v1alpha1
+kind: ApplicationSet
+metadata:
+  name: clickhouse-operator
+  namespace: argocd
+spec:
+  goTemplate: true
+  goTemplateOptions:
+    - missingkey=error
+
+  generators:
+    - matrix:
+        generators:
+          - clusters:
+              selector:
+                matchLabels:
+                  clickhouse-operator/enabled: "true"
+
+          - plugin:
+              configMapRef:
+                name: argocd-appset-params-template-plugin
+              input:
+                parameters:
+                  context:
+                    cluster:
+                      name: "{{ .name }}"
+                      nameNormalized: "{{ .nameNormalized }}"
+
+                  params:
+                    appName: clickhouse-operator
+                    namespace: clickhouse-operator
+                    repoURL: https://docs.altinity.com/clickhouse-operator
+                    chart: altinity-clickhouse-operator
+                    targetRevision: 0.26.2
+
+                  defaults:
+                    serviceMonitor:
+                      enabled: false
+                    operator:
+                      resources: {}
+                    metrics:
+                      resources: {}
+
+                  selectorOverrides:
+                    - path: context.cluster.name
+                      overrides:
+                        do-dev0-dev-ctrl1:
+                          serviceMonitor:
+                            enabled: true
+                          operator:
+                            resources:
+                              requests:
+                                cpu: 100m
+                                memory: 320Mi
+                          metrics:
+                            resources:
+                              requests:
+                                cpu: 50m
+                                memory: 64Mi
+
+  template:
+    metadata:
+      name: "{{ .params.appName }}-{{ .context.cluster.nameNormalized }}"
+    spec:
+      project: default
+      destination:
+        name: "{{ .context.cluster.name }}"
+        namespace: "{{ .params.namespace }}"
+      source:
+        repoURL: "{{ .params.repoURL }}"
+        chart: "{{ .params.chart }}"
+        targetRevision: "{{ .params.targetRevision }}"
+        helm:
+          releaseName: "{{ .params.appName }}"
+          values: |
+            {{- toYaml .result | nindent 12 }}