Skip to content

update UDF to account for different Nova variants#9717

Open
jaredsnyder wants to merge 4 commits into
mainfrom
nova_udf_fixes
Open

update UDF to account for different Nova variants#9717
jaredsnyder wants to merge 4 commits into
mainfrom
nova_udf_fixes

Conversation

@jaredsnyder

Copy link
Copy Markdown
Contributor

There are two layouts with the Nova breakpoints: Sections and Grid. We want to make the distinction to make it easier to track changes. The biggest risk is that it will break the forecast content inputs table, but it will have not effect as presently constituted

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR splits the single NOVA layout value emitted by newtab.determine_grid_layout_v1 into NOVA_SECTION and NOVA_GRID (based on is_section), updates newtab.determine_tiles_per_row_v1 to match on both new values, and updates the tests and READMEs accordingly.

The core logic and CASE ordering are correct, and the tiles-per-row breakpoints are shared between both Nova variants as documented. I confirmed no other query in the repo hardcodes the old 'NOVA' literal, and the two consuming views (newtab_visits_daily, newtab_component_content) don't branch on it, so the rename is safe for downstream consumers. Two minor items are noted inline.

Comment thread sql/mozfun/newtab/determine_tiles_per_row_v1/udf.sql Outdated
Comment thread sql/mozfun/newtab/determine_tiles_per_row_v1/README.md Outdated
@scholtzan

This comment has been minimized.

@scholtzan

This comment has been minimized.

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants