update UDF to account for different Nova variants#9717
Open
jaredsnyder wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
This PR splits the single NOVA layout value emitted by newtab.determine_grid_layout_v1 into NOVA_SECTION and NOVA_GRID (based on is_section), updates newtab.determine_tiles_per_row_v1 to match on both new values, and updates the tests and READMEs accordingly.
The core logic and CASE ordering are correct, and the tiles-per-row breakpoints are shared between both Nova variants as documented. I confirmed no other query in the repo hardcodes the old 'NOVA' literal, and the two consuming views (newtab_visits_daily, newtab_component_content) don't branch on it, so the rename is safe for downstream consumers. Two minor items are noted inline.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Integration report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two layouts with the Nova breakpoints: Sections and Grid. We want to make the distinction to make it easier to track changes. The biggest risk is that it will break the forecast content inputs table, but it will have not effect as presently constituted