Skip to content

Commit cf7a324

Browse files
committed
[audioplugins] give AudioPluginState::Undefined an explicit wire name
audioPluginStateName(Undefined) returned "" — indistinguishable from an unknown name. Add an explicit Undefined<->"Undefined" entry so the mapping is bijective. writePluginsInfo still omits the state field for Undefined entries, so the JSON wire format is unchanged.
1 parent 36ddee8 commit cf7a324

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

framework/audioplugins/audiopluginstypes.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ namespace detail {
131131
inline const std::map<AudioPluginState, std::string>& audioPluginStateNames()
132132
{
133133
static const std::map<AudioPluginState, std::string> NAMES = {
134+
{ AudioPluginState::Undefined, "Undefined" },
134135
{ AudioPluginState::Discovered, "Discovered" },
135136
{ AudioPluginState::Validated, "Validated" },
136137
{ AudioPluginState::Missing, "Missing" },

framework/audioplugins/internal/knownaudiopluginsregister.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,9 @@ Ret KnownAudioPluginsRegister::writePluginsInfo()
351351
obj.set("meta", metaToJson(info.meta, runtimeOnly));
352352
obj.set("path", info.path.toStdString());
353353

354-
// Skip writing the state field for Undefined (would serialize as "");
355-
// load() reads a missing/empty "state" as Undefined too, so this round-trips.
354+
// Omit the state field for Undefined entries — a written entry always
355+
// carries a concrete state. load() reads a missing "state" back as
356+
// Undefined, so this round-trips.
356357
if (info.state != AudioPluginState::Undefined) {
357358
obj.set("state", audioPluginStateName(info.state));
358359
}

0 commit comments

Comments
 (0)