Skip to content

feat(referencePicker): introduce getReferenceWithPicker() #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mejo- wants to merge 2 commits into
base: main
Choose a base branch
from

fix(NcRichText): emit PickerSubmitResult in `onSubmit` where possible

9e64b40
Select commit
Loading
Failed to load commit list.
Open

feat(referencePicker): introduce getReferenceWithPicker() #8532

fix(NcRichText): emit PickerSubmitResult in `onSubmit` where possible
9e64b40
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 18, 2026 in 0s

54.31% (-0.26%) compared to 1b5d050

View this Pull Request on Codecov

54.31% (-0.26%) compared to 1b5d050

Details

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.31%. Comparing base (1b5d050) to head (9e64b40).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
src/functions/reference/referencePickerModal.ts 0.00% 15 Missing and 3 partials ⚠️
...chText/NcReferencePicker/NcCustomPickerElement.vue 0.00% 2 Missing and 1 partial ⚠️
...NcRichText/NcReferencePicker/NcReferencePicker.vue 0.00% 2 Missing ⚠️
...ts/NcRichText/NcReferencePicker/NcProviderList.vue 0.00% 1 Missing ⚠️
...ts/NcRichText/NcReferencePicker/NcRawLinkInput.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8532      +/-   ##
==========================================
- Coverage   54.57%   54.31%   -0.26%     
==========================================
  Files         106      106              
  Lines        3443     3461      +18     
  Branches     1004     1009       +5     
==========================================
+ Hits         1879     1880       +1     
- Misses       1323     1336      +13     
- Partials      241      245       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov