Remove old data config value check

[Sukh-P]

This check https://github.com/openclimatefix/site-forecast-app/blob/main/site_forecast_app/models/pvnet/utils.py#L82-L84 and removal of live_delay_minutes is outdated as we no longer have this value in data config, we should be able to remove this

[AnujNayak108]

Hello, if this issue is open for contribution, I’d be happy to work on it.

Just to clarify: the idea is to confirm whether live_delay_minutes is still used anywhere else in the repo, and if there are no other references, simply remove the check — is that correct?

[Sukh-P]

Hi @AnujNayak108, thanks for offering to pick this up, this is definitely one we are open to contributions on so I've assigned you to the issue.

So yes a bit more detail on it, yes essentially you're correct I believe that config parameter live_delay_minutes is no longer in use and the check is now redundant, so checking for references in this repo but also it would be worth checking the source of the config generation which is here, also worth checking in some of the HF repos we grab this config from such as this one, if it looks like it's not present in any of these places then I think it's fine to remove this check, thanks!

Let me know if you have anymore questions

[AnujNayak108]

Thanks a lot for the clarification

I’ll start by searching for any references to live_delay_minutes in this repo, the config generation source you linked, and the relevant HF repos. If it looks unused across all of them, I’ll go ahead and remove the check.

Will update here if I run into anything unclear!

[AnujNayak108]

Hi , I looked into this.

• In this repo, I only found live_delay_minutes in site_forecast_app/models/pvnet/utils.py, where it’s popped from satellite_config.
• I searched the config generation repo as suggested → not present there.
• I also checked the HuggingFace configs and there’s no live_delay_minutes in the satellite section or elsewhere.

So it seems this field is no longer used anywhere, and the check in utils.py can safely be removed.
Would you like me to open a PR removing those lines?

[Sukh-P]

Nice thank you and yes please!

[Anvayt24]

hello @Sukh-P if this issue is still open i'd like to work on this. I see there's been last activity related to this issue on PR #78 2-3 week back!