Error patching during cmake

[winks]

First of all, this is trying to build using the Archlinux AUR package, because I have not yet had time to recreate the build env from scratch, but bear with me.

Also the PKGBUILD is one of the most "boring" ones I have ever seen: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=textadept

The only thing that could be wrong or non-standard would be the cmake flags, but this shoudl not apply.

So I get this error:

[ 33%] No update step for 'termkey-populate'
[ 44%] Performing patch step for 'termkey-populate'
patching file driver-win-pdcurses.c
patching file termkey-internal.h
patching file termkey.c
Hunk #7 succeeded at 520 (offset -6 lines).
File termkey.h is read-only; trying to patch anyway
patching file termkey.h
make[2]: *** [CMakeFiles/termkey-populate.dir/build.make:118: termkey-populate-prefix/src/termkey-populate-stamp/termkey-populate-patch] Error 2
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/termkey-populate.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
CMake Error at /usr/share/cmake/Modules/FetchContent.cmake:1928 (message):
  Build step for termkey failed: 2
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FetchContent.cmake:1619 (__FetchContent_populateSubbuild)
  /usr/share/cmake/Modules/FetchContent.cmake:2155:EVAL:2 (__FetchContent_doPopulation)
  /usr/share/cmake/Modules/FetchContent.cmake:2155 (cmake_language)
  /usr/share/cmake/Modules/FetchContent.cmake:2394 (__FetchContent_Populate)
  CMakeLists.txt:102 (FetchContent_MakeAvailable)


-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
    Aborting...

And lo and behold, when I download the termkey release from https://www.leonerd.org.uk/code/libtermkey/libtermkey-0.22.tar.gz and unpack it manually, the to-be-patched termkey.h is actually not writable.

I have never seen patch fail on this anywhere, but maybe I also never tried it on read-only files.

So the problem should be there in any build - but I am wondering why it would fail here and nowhere else. I dug through this bug tracker and also the arch one, and textadept has been packaged for a logn time.

In the end I fixed it with my own patch wrapper shell script in CMakeLists.txt that would chmod termkey.h and then it built just fine.

So TLDR: I have no idea how this ever worked, I faintly remember building textadept myself after 2019 and before 2024 but I don't have access to that machine anymore.

And sorry I'm posting this here first but it feels like a potential upstream issue.

[orbitalquark]

Good question. I, too, have never seen this happen before. My termkey.h is also read-only, but it was successfully patched. Textadept builds on CI for all three platforms, which indicates there is no issue with that read-only file. I'm not sure what to do about this.

[winks]

Trying to repro on Ubuntu and Arch in a container.

TLDR: could not repro, although both termkey.h are read-only, I never get the patch warning - only on my physical box.

FROM ubuntu:22.04

RUN apt-get update
RUN apt-get -y install \
	qtbase5-dev-tools build-essential cmake libegl1-mesa-dev lua5.4 qtbase5-dev clang patch \
	--no-install-recommends

docker build -t ta1 .
docker run --rm -it -v "$PWD:/app" ta1:latest bash

cd /app/textadept
cmake -S . -B build -D CMAKE_BUILD_TYPE=RelWithDebInfo \
        -D CMAKE_INSTALL_PREFIX=build_dir/install
cmake --build build

###
GNU patch 2.7.6
cmake version 3.22.1

Unsurprisingly this works, just like CI (I guessed the deps)
Also no mention of the read-only termkey.h

-- Populating termkey
-- Configuring done
-- Generating done
-- Build files have been written to: /app/textadept/build/_deps/termkey-subbuild
[ 11%] Creating directories for 'termkey-populate'
[ 22%] Performing download step (download, verify and extract) for 'termkey-populate'
-- Downloading...
   dst='/app/textadept/build/_deps/termkey-subbuild/termkey-populate-prefix/src/libtermkey-0.22.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://www.leonerd.org.uk/code/libtermkey/libtermkey-0.22.tar.gz'
-- [download 35% complete]
-- [download 71% complete]
-- [download 100% complete]
-- Downloading... done
-- extracting...
     src='/app/textadept/build/_deps/termkey-subbuild/termkey-populate-prefix/src/libtermkey-0.22.tar.gz'
     dst='/app/textadept/build/_deps/termkey-src'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 33%] No update step for 'termkey-populate'
[ 44%] Performing patch step for 'termkey-populate'
patching file driver-win-pdcurses.c
patching file termkey-internal.h
patching file termkey.c
Hunk #7 succeeded at 520 (offset -6 lines).
patching file termkey.h
[ 55%] No configure step for 'termkey-populate'
[ 66%] No build step for 'termkey-populate'
[ 77%] No install step for 'termkey-populate'
[ 88%] No test step for 'termkey-populate'
[100%] Completed 'termkey-populate'
[100%] Built target termkey-populate

Now the same thing with arch

FROM archlinux/archlinux

RUN pacman --noconfirm -Syu
RUN pacman --noconfirm -S \
qt5-base cmake lua clang patch make

docker build -t ta2 .
docker run --rm -it -v "$PWD:/app" ta2:latest bash

cd /app/textadept
cmake -S . -B build2 -D CMAKE_BUILD_TYPE=RelWithDebInfo \
        -D CMAKE_INSTALL_PREFIX=build_dir/install
cmake --build build2

###
GNU patch 2.8
cmake version 4.2.1

-- Populating termkey
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: /app/textadept/build2/_deps/termkey-subbuild
[ 11%] Creating directories for 'termkey-populate'
[ 22%] Performing download step (download, verify and extract) for 'termkey-populate'
-- Downloading...
   dst='/app/textadept/build2/_deps/termkey-subbuild/termkey-populate-prefix/src/libtermkey-0.22.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://www.leonerd.org.uk/code/libtermkey/libtermkey-0.22.tar.gz'
-- [download 35% complete]
-- [download 71% complete]
-- [download 100% complete]
-- Downloading... done
-- extracting...
     src='/app/textadept/build2/_deps/termkey-subbuild/termkey-populate-prefix/src/libtermkey-0.22.tar.gz'
     dst='/app/textadept/build2/_deps/termkey-src'
-- extracting... [tar xf]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 33%] No update step for 'termkey-populate'
[ 44%] Performing patch step for 'termkey-populate'
patching file driver-win-pdcurses.c
patching file termkey-internal.h
patching file termkey.c
Hunk #7 succeeded at 520 (offset -6 lines).
patching file termkey.h
[ 55%] No configure step for 'termkey-populate'
[ 66%] No build step for 'termkey-populate'
[ 77%] No install step for 'termkey-populate'
[ 88%] No test step for 'termkey-populate'
[100%] Completed 'termkey-populate'
[100%] Built target termkey-populate