fix: align destroy event with polymorphic associations and update specs

Author: paul-mothapo

lib/paper_trail/events/destroy.rb

@@ -13,8 +13,9 @@ class Destroy < Base
       # @api private
       def data
         data = {
-          item_id: @record.id,
-          item_type: @record.class.base_class.name,
+          # Keep destroy aligned with create/update so Rails resolves
+          # `item_type` via the polymorphic association.
+          item: @record,
           event: @record.paper_trail_event || "destroy",
           whodunnit: PaperTrail.request.whodunnit
         }

spec/paper_trail/events/destroy_spec.rb

@@ -2,6 +2,18 @@
 
 require "spec_helper"
 
+# Regression fixture for overridden polymorphic type names.
+module PolymorphicNameOverride
+  class Widget < ApplicationRecord
+    self.table_name = "widgets"
+    has_paper_trail
+
+    def self.polymorphic_name
+      "Widget"
+    end
+  end
+end
+
 module PaperTrail
   module Events
     ::RSpec.describe Destroy do
@@ -12,10 +24,22 @@ module Events
             path_to_stardom: "Mexican radio"
           )
           data = described_class.new(carter, true).data
-          expect(data[:item_type]).to eq("Family::Family")
+          version = PaperTrail::Version.new(data)
+          expect(data[:item]).to eq(carter)
+          expect(version.item_type).to eq("Family::Family")
           expect(data[:item_subtype]).to eq("Family::CelebrityFamily")
         end
 
+        # Destroy versions should respect `polymorphic_name` just like create/update.
+        it "uses polymorphic_name for destroy versions" do
+          widget = PolymorphicNameOverride::Widget.create!(name: "Henry")
+          widget.update!(name: "Harry")
+          widget.destroy
+
+          expect(widget.versions.pluck(:event)).to eq(%w[create update destroy])
+          expect(widget.versions.pluck(:item_type).uniq).to eq(["Widget"])
+        end
+
         context "with skipper" do
           let(:skipper) { Skipper.create!(another_timestamp: Time.current) }
           let(:data) { described_class.new(skipper, false).data }