Make websocket disconnect codes explicit#6678
Merged
SteffenDE merged 3 commits intoMay 22, 2026
Merged
Conversation
Credit to dl-alexandre for this (dl-alexandre@e055ec2)
jeregrine
approved these changes
May 15, 2026
SteffenDE
approved these changes
May 15, 2026
Contributor
|
Can you fix the tests? |
Member
Author
|
Tests updated! |
zekedou
added a commit
to combo-lab/combo
that referenced
this pull request
May 22, 2026
SteffenDE
reviewed
May 22, 2026
Co-authored-by: Steffen Deusch <steffen@deusch.me>
Contributor
|
Thank you @mtrudel! @dl-alexandre was blocked because of numerous low-quality AI contributions. Looking at the bandit issue, I'm not even sure how much of the communication is done by Dalton Alexandre, the person. Quoting:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit to @dl-alexandre for this; they had worked it up on a bandit issue, but since their org is blocked from opening PRs on the phoenix project I'm doing it by proxy.
I've triaged this from Bandit/Cowboy's perspective and it's legit.