fix(extgen): extract Go function bodies via go/ast instead of brace counting#2379
Merged
alexandre-daubois merged 1 commit intoMay 12, 2026
Conversation
Member
|
Needs a rebase |
alexandre-daubois
force-pushed
the
fix/extgen-ast-body-extraction
branch
from
7103de9 to
42a788a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the internal/extgen generator’s Go source extraction logic to use go/ast parsing rather than manual brace counting, making function/method body extraction resilient to braces appearing in strings and comments.
Changes:
- Replace line-scanning + brace counting in
FuncParserwithgo/parser+ AST-based source slicing. - Replace line-scanning + brace counting in class method parsing with AST-based extraction.
- Add shared AST utilities and a regression test covering braces inside strings/comments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/extgen/funcparser.go | Parse Go files via go/parser, associate //export_php:function directives via AST doc comments, and extract function source via node offsets. |
| internal/extgen/funcparser_test.go | Adds a regression test ensuring braces in strings/comments don’t break extraction. |
| internal/extgen/classparser.go | Migrates method extraction to AST-based parsing and removes brace-counting scanner logic. |
| internal/extgen/astutil.go | Adds reusable helpers for directive lookup, node source extraction, and orphan-directive detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexandre-daubois
force-pushed
the
fix/extgen-ast-body-extraction
branch
from
42a788a to
0629082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.