ext/gd/tests/gh17349.phpt: require PNG support#21988
Closed
orlitzky wants to merge 1 commit intophp:PHP-8.3from
Closed
ext/gd/tests/gh17349.phpt: require PNG support#21988orlitzky wants to merge 1 commit intophp:PHP-8.3from
orlitzky wants to merge 1 commit intophp:PHP-8.3from
Conversation
This test loads a PNG image, so if an external libgd is being used, it has to support PNG.
Member
|
Thanks, albeit I would say 1 PR is enough to fix gd tests. |
Contributor
Author
|
Sorry, was in a hurry trying to get the security releases out. |
Contributor
Author
|
And sorry again in advance for the one needed to handle c1c6520 :) I'm testing 8.2, 8.3, 8.4, and 8.5 in succession, so not hitting them all at once. |
Member
|
No problem take your time :) |
Contributor
Author
|
moving to #21987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test loads a PNG image, so if an external libgd is being used, it has to support PNG.