Category class is overriding the SKStoreProductViewController methods

[jangirtony2009]

---

@implementation SKStoreProductViewController (CustomMethods)

- (void)touchesBegan:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event {
    [super touchesBegan:touches withEvent:event];
    if (@available(iOS 17.2, *)) {
        [self loadProductWithParameters:productParameters completionBlock:nil];
    }
}

- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
    return UIInterfaceOrientationMaskAll;
}

- (BOOL)shouldAutorotate {
    UIInterfaceOrientationMask applicationSupportedOrientations = [[UIApplication sharedApplication] supportedInterfaceOrientationsForWindow:[[UIApplication sharedApplication] keyWindow]];
    UIInterfaceOrientationMask viewControllerSupportedOrientations = [self supportedInterfaceOrientations];
    return viewControllerSupportedOrientations & applicationSupportedOrientations;
}

@end

I encountered an issue because of overridden methods in the SKStoreProductViewController category class. My view controller logic is not getting honored. This is affecting my app's logic. I suspect this might be related to the implementation in Pubnative's HyBid iOS SDK.

According to Apple’s guidelines, while creating category classes is permissible, overriding class methods within them can alter the behavior of the entire app.

[josejacoboct]

Hi @jangirtony2009 Thanks so much for raising this issue. We are aware of the alerts that Apple mentioned regarding subclassing or embedding the SKStoreProductViewController. Could you please share to us a bit more how this part is affecting your app?

Thanks in advance.
Jacobo Contreras.

[jangirtony2009]

@josejacoboct
Thank you for your response.

I wanted to provide more context on how this issue is impacting our app.

Our current logic for displaying the SKStoreProductViewController involves ensuring it appears in landscape mode whenever possible. To achieve this, we set the shouldAutorotate flag to NO to prevent crashes. Here’s the relevant implementation:

Try out this sample code with and without the hybrid SDK. The crash arises because the hybrid SDK seems to be overriding my settings for the shouldAutorotate flag.

*** Terminating app due to uncaught exception 'UIApplicationInvalidInterfaceOrientation', reason: 'Supported orientations has no common orientation with the application, and [SKStoreProductViewController shouldAutorotate] is returning YES'

import UIKit
import StoreKit
import WebKit

@available(iOS 16.0, *)
class ViewController: UIViewController, SKStoreProductViewControllerDelegate {
    
    var productViewController: SKStoreProductViewController?
    
    override func viewDidLoad() {
        super.viewDidLoad()
        self.modalPresentationStyle = .fullScreen
        showProductView()
    }

   
    override var supportedInterfaceOrientations: UIInterfaceOrientationMask {
        .landscape
    }
    
    override var shouldAutorotate: Bool {
        false
    }
    

    func showProductView() {
        productViewController = SKStoreProductViewController()
        productViewController?.delegate = self
        
        
        let dict = [
            "id": 932493382
        ] as [String : Any]
        
        productViewController?.loadProduct(withParameters: dict) { [weak self] (success, error) in
            if success {
                self?.openStore()
            } else {
                print("Failed to load product view controller with error: \(error?.localizedDescription ?? "")")
            }
        }
    }
    
    func openStore() {
        if let productViewController = self.productViewController {
            self.present(productViewController, animated: true) {
             
            }
        }
    }
        
    func productViewControllerDidFinish(_ viewController: SKStoreProductViewController) {
        viewController.dismiss(animated: true, completion: nil)
    }
}


@available(iOS 13.0, *)
extension AppDelegate{
    func application(_ application: UIApplication, supportedInterfaceOrientationsFor window: UIWindow?) -> UIInterfaceOrientationMask {
        .portrait
    }
}

[josejacoboct]

@jangirtony2009 Thanks for the context. We are aware of your situation and working on it, as soon as is possible I'll bring you some news about your case.

[jangirtony2009]

@josejacoboct Any ETA for this fix?

[josejacoboct]

@jangirtony2009 We are currently working on it, and the most probable scenario is to include a fix in our next release (at the end of the current month).

[josejacoboct]

@jangirtony2009 I hope this comment finds you well. To keep you posted, our next version (3.1) will contain a fix for your issue, we are hoping to publish this version in the middle of this month, in case this ETA moves I'll let you know. Thanks for your understanding and sorry for the inconvenience this might cause.

[riteshghodrao]

Hi @josejacoboct ,
We see this version has not yet been released, do you have an updated ETA on this?

[josejacoboct]

Hello @riteshghodrao, thanks for your comment. My superiors shared with me that our next release date will be in September, we apologize for the last delays regarding our release ETA and expect that we aren't going to put it off again. Once again, thanks for your understanding, and sorry for the inconvenience this may cause.

I'll keep you posted about the situation and please, feel free to ping me for further questions.

[josejacoboct]

@riteshghodrao @jangirtony2009 I hope this comment finds you well. Currently, HyBid SDK team is working on the last steps to deliver our new release, we apologize for this last delay, but we can ensure that our next version will come in the following days with the fix for the issue you have been facing

[josejacoboct]

@riteshghodrao I hope you are doing well. Finally, the HyBid SDK team released our last SDK version (3.0.4) which includes the fix for this issue. Please, try updating our SDK version and share your comments if this bug is still reproducible or not. Thanks in advance and thank you for your patience.

[riteshghodrao]

Hi @josejacoboct ,really appreciate your updates on this. we will test this out and let you know. thanks.

[josejacoboct]

@riteshghodrao no problem, just a small detail, I mixed the versions for our SDK, the version that includes the fix is available in 3.1.0

[josejacoboct]

@riteshghodrao I hope you are doing well, I would like to ask you, did the new SDK version help to fix your bug? May I close this issue?

[jangirtony2009]

@josejacoboct This does not seem to be the right approach to implement this. The issue with this code is that you are attempting to retrieve the value using the low-level API. If a crash occurs due to memory corruption, it will result in an incorrect crash thread stack.

Code link

// Method to detect during run time whether the presentingViewController overrides or not shouldAutorotate & supportedInterfaceOrientations method (due the use of a Category)


BOOL doesClassHasMethod(Class cls, SEL sel) {
    unsigned int methodCount;
    Method *methods = class_copyMethodList(cls, &methodCount);

    BOOL result = NO;
    for (unsigned int i = 0; i < methodCount; ++i) {
        if (method_getName(methods[i]) == sel) {
            result = YES;
            break;
        }
    }

    free(methods);
    return result;
}

Instead of creating a category on SKStoreProductViewController, it is recommended to implement the shouldAutorotate and supportedInterfaceOrientations methods in your own view controller. When your view controller presents the SKStoreProductViewController, the system will ask the presenting view controller (your view controller) for the supported orientation and auto-rotation preferences.