Objects satisfying the core.types.Lock interface should also be hashable#11333
Merged
Conversation
for more information, see https://pre-commit.ci
jonathandung
changed the title
core.types.Lock interface should also be hashable
dcherian
approved these changes
May 15, 2026
Contributor
|
Failures appear unrelated. |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
maxrjones
pushed a commit
to maxrjones/xarray
that referenced
this pull request
May 21, 2026
…hable (pydata#11333) * Add __hash__ to core.types.Lock protocol * Implement hash in `Lock` protocol * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parent: python/typeshed#15754.
Basically, because
backends.locks.CombinedLock.__init__usessetto remove duplicates from a sequence of instances of classes implementing theLockinterface, all locks must be hashable in addition to implementing the current methods.Checklist
N/A