operations.selinux.port: fix a bug where the op would not find existing labels if sepolicy command was missing from the host (#1654)

Author: yacoob

src/pyinfra/operations/selinux.py

@@ -173,7 +173,7 @@ def port(protocol: Protocol | str, port_num: int, se_type: str | None = None, pr
         current = host.get_fact(SEPort, protocol=protocol, port=port_num)
     else:
         port_info = host.get_fact(SEPorts)
-        current = port_info.get(protocol, {}).get(str(port_num), "")
+        current = port_info.get(protocol, {}).get(port_num, "")
 
     if present:
         option = "-a" if current == "" else ("-m" if current != se_type else "")
@@ -191,4 +191,4 @@ def port(protocol: Protocol | str, port_num: int, se_type: str | None = None, pr
         if not direct_get:
             if protocol not in port_info:
                 port_info[protocol] = {}
-            port_info[protocol][str(port_num)] = new_type
+            port_info[protocol][port_num] = new_type

tests/operations/selinux.port/add_different.json

@@ -0,0 +1,14 @@
+args:
+  - tcp
+  - 22
+  - ssh_port_t
+kwargs:
+  present: true
+facts:
+  selinux.SEPorts:
+    tcp:
+      22: xray_port_t
+  server.Which:
+    command=sepolicy: null
+commands:
+  - semanage port -m -t ssh_port_t -p tcp 22

tests/operations/selinux.port/add_different.yaml

@@ -0,0 +1,14 @@
+args:
+  - tcp
+  - 22
+  - ssh_port_t
+kwargs:
+  present: true
+facts:
+  selinux.SEPorts:
+    tcp:
+      22: ""
+  server.Which:
+    command=sepolicy: null
+commands:
+  - semanage port -a -t ssh_port_t -p tcp 22

tests/operations/selinux.port/add_not_existing.json

@@ -0,0 +1,14 @@
+args:
+  - tcp
+  - 22
+  - ssh_port_t
+kwargs:
+  present: true
+facts:
+  selinux.SEPorts:
+    udp:
+      53: dns_port_t
+  server.Which:
+    command=sepolicy: null
+commands:
+  - semanage port -a -t ssh_port_t -p tcp 22

tests/operations/selinux.port/add_not_existing.yaml

@@ -0,0 +1,14 @@
+args:
+  - tcp
+  - 22
+  - ssh_port_t
+kwargs:
+  present: true
+facts:
+  selinux.SEPorts:
+    tcp:
+      22: ssh_port_t
+  server.Which:
+    command=sepolicy: null
+commands: []
+noop_description: "setype for 'tcp/22' is already 'ssh_port_t'"