facts.crontab: match full crontab(5) env var syntax (#1678)

Author: wowi42

src/pyinfra/facts/crontab.py

@@ -102,7 +102,21 @@ def to_json(self):
         return self.commands
 
 
-_crontab_env_re = re.compile(r"^\s*([A-Z_]+)=(.*)$")
+# crontab(5) env line: ``name = value`` with optional spaces around ``=``. The
+# name may be a bare identifier or placed in matching single/double quotes; the
+# value runs to end-of-line (the caller handles any quoting in the value).
+_crontab_env_re = re.compile(
+    r"""
+    ^\s*
+    (?:
+        "[^"]*"                         # "quoted name"
+      | '[^']*'                         # 'quoted name'
+      | [A-Za-z_][A-Za-z0-9_]*          # bare identifier
+    )
+    \s*=
+    """,
+    re.VERBOSE,
+)
 
 
 class Crontab(FactBase[CrontabFile]):

tests/facts/crontab.Crontab/env_variables.json

@@ -0,0 +1,34 @@
+{
+    "command": "crontab -l || true",
+    "requires_command": "crontab",
+    "output": [
+        "MAILTO=me@example.com",
+        "CRON_TZ=Europe/Amsterdam",
+        "@reboot echo rebooted",
+        "0 0 * * * apt update"
+    ],
+    "fact": [
+        {
+            "env": "MAILTO=me@example.com",
+            "comments": []
+        },
+        {
+            "env": "CRON_TZ=Europe/Amsterdam",
+            "comments": []
+        },
+        {
+            "command": "echo rebooted",
+            "special_time": "@reboot",
+            "comments": []
+        },
+        {
+            "command": "apt update",
+            "minute": 0,
+            "hour": 0,
+            "month": "*",
+            "day_of_month": "*",
+            "day_of_week": "*",
+            "comments": []
+        }
+    ]
+}

tests/facts/crontab.Crontab/env_variables_spaced_and_lowercase.json

@@ -0,0 +1,33 @@
+{
+    "command": "crontab -l || true",
+    "requires_command": "crontab",
+    "output": [
+        "MAILTO = me@example.com",
+        "cron_tz = Europe/Amsterdam",
+        "SHELL=/bin/bash",
+        "0 * * * * echo hi"
+    ],
+    "fact": [
+        {
+            "env": "MAILTO = me@example.com",
+            "comments": []
+        },
+        {
+            "env": "cron_tz = Europe/Amsterdam",
+            "comments": []
+        },
+        {
+            "env": "SHELL=/bin/bash",
+            "comments": []
+        },
+        {
+            "command": "echo hi",
+            "minute": 0,
+            "hour": "*",
+            "month": "*",
+            "day_of_month": "*",
+            "day_of_week": "*",
+            "comments": []
+        }
+    ]
+}