operations.server: list BSD variants explicitly in server.service

Replace the "not Linux" guard with an explicit (FreeBSD, OpenBSD, NetBSD,
DragonFly) set so the bsdinit branch only matches known BSDs rather than
every non-Linux host that happens to expose /etc/rc.d. NetBSD behaves like
FreeBSD (ships service(8)), so add a fixture to cover that path.

Author: wowi42

src/pyinfra/operations/server.py

@@ -572,12 +572,15 @@ def service(
     elif host.get_fact(Which, command="sv"):
         service_operation = runit.service
 
-    # NOTE: important that we are not Linux here because /etc/rc.d will exist but checking it's
-    # contents may trigger things (like a reboot: https://github.com/Fizzadar/pyinfra/issues/819).
-    # Must also run before the sysvinit check: BSDs ship `service` in base (distinct from the
-    # Linux sysvinit wrapper), so matching on Which command="service" first would misroute FreeBSD
+    # NOTE: must run before the sysvinit check: BSDs ship `service` in base (distinct from the
+    # Linux sysvinit wrapper), so matching on Which command="service" first would misroute BSD
     # hosts to sysvinit. See https://github.com/pyinfra-dev/pyinfra/issues/1496.
-    elif host.get_fact(Os) != "Linux" and bool(host.get_fact(Directory, path="/etc/rc.d")):
+    # The OS list is explicit (rather than "not Linux") so other /etc/rc.d-having systems are not
+    # accidentally routed through bsdinit; see https://github.com/Fizzadar/pyinfra/issues/819 for
+    # the original motivation to exclude Linux here.
+    elif host.get_fact(Os) in ("FreeBSD", "OpenBSD", "NetBSD", "DragonFly") and bool(
+        host.get_fact(Directory, path="/etc/rc.d")
+    ):
         service_operation = bsdinit.service
 
     elif (

tests/operations/server.service/start_rcd_netbsd.json

@@ -0,0 +1,26 @@
+{
+    "args": ["nginx"],
+    "facts": {
+        "server.Os": "NetBSD",
+        "bsdinit.RcdStatus": {
+            "nginx": false
+        },
+        "server.Which": {
+            "command=systemctl": false,
+            "command=initctl": false,
+            "command=rc-service": false,
+            "command=sv": false,
+            "command=service": "/usr/sbin/service"
+        },
+        "files.Directory": {
+            "path=/etc/init.d": false,
+            "path=/etc/rc.d": true
+        },
+        "files.Link": {
+            "path=/etc/init.d": false
+        }
+    },
+    "commands": [
+        "test -e /etc/rc.d/nginx && /etc/rc.d/nginx start || /usr/local/etc/rc.d/nginx start"
+    ]
+}